Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 176933013: Pass rootNode by reference when constructing node lists / collections (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
adamk
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, rwlbuis
Visibility:
Public.

Description

Pass rootNode by reference when constructing node lists / collections Pass rootNode by reference when constructing node lists / collections to make it clear that the rootNode cannot be null. Their implementation already relies on the fact that the rootNode cannot be null. R=adamk@chromium.org, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168417

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -79 lines) Patch
M Source/core/dom/ChildNodeList.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ChildNodeList.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/ClassCollection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ClassCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/EmptyNodeList.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/dom/LiveNodeList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/LiveNodeListBase.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/NameNodeList.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/NameNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/NodeRareData.h View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/TagCollection.h View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/TagCollection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLAllCollection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLAllCollection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLCollection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLCollection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormControlsCollection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormControlsCollection.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLNameCollection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLNameCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptionsCollection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLOptionsCollection.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTableRowsCollection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableRowsCollection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/LabelableElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/LabelsNodeList.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/LabelsNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/RadioNodeList.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/RadioNodeList.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 9 months ago (2014-03-04 04:01:39 UTC) #1
adamk
rslgtm
6 years, 9 months ago (2014-03-04 19:51:55 UTC) #2
adamk
The CQ bit was checked by adamk@chromium.org
6 years, 9 months ago (2014-03-04 19:51:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/176933013/1
6 years, 9 months ago (2014-03-04 19:53:12 UTC) #4
Inactive
6 years, 9 months ago (2014-03-05 02:26:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r168417 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698