Pass rootNode by reference when constructing node lists / collections

Source/core/html/HTMLOptionsCollection.cpp

 /*
  * Copyright (C) 2006, 2011, 2012 Apple Computer, Inc.
  * Copyright (C) 2014 Samsung Electronics. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 13 matching lines @@
 
 #include "bindings/v8/ExceptionMessages.h"
 #include "bindings/v8/ExceptionState.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/NamedNodesCollection.h"
 #include "core/html/HTMLOptionElement.h"
 #include "core/html/HTMLSelectElement.h"
 
 namespace WebCore {
 
-HTMLOptionsCollection::HTMLOptionsCollection(ContainerNode* select)
+HTMLOptionsCollection::HTMLOptionsCollection(ContainerNode& select)
     : HTMLCollection(select, SelectOptions, DoesNotOverrideItemAfter)
 {
-    ASSERT(select->hasTagName(HTMLNames::selectTag));
+    ASSERT(select.hasTagName(HTMLNames::selectTag));
     ScriptWrappable::init(this);
 }
 
 void HTMLOptionsCollection::supportedPropertyNames(Vector<String>& names)
 {
     // As per http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#htmloptionscollection:
     // The supported property names consist of the non-empty values of all the id and name attributes of all the elements
     // represented by the collection, in tree order, ignoring later duplicates, with the id of an element preceding its
     // name if it contributes both, they differ from each other, and neither is the duplicate of an earlier entry.
     HashSet<AtomicString> existingNames;
     unsigned length = this->length();
     for (unsigned i = 0; i < length; ++i) {
         Element* element = item(i);
         ASSERT(element);
         const AtomicString& idAttribute = element->getIdAttribute();
         if (!idAttribute.isEmpty()) {
             HashSet<AtomicString>::AddResult addResult = existingNames.add(idAttribute);
             if (addResult.isNewEntry)
                 names.append(idAttribute);
         }
         const AtomicString& nameAttribute = element->getNameAttribute();
         if (!nameAttribute.isEmpty()) {
             HashSet<AtomicString>::AddResult addResult = existingNames.add(nameAttribute);
             if (addResult.isNewEntry)
                 names.append(nameAttribute);
         }
     }
 }
 
-PassRefPtr<HTMLOptionsCollection> HTMLOptionsCollection::create(ContainerNode* select, CollectionType)
+PassRefPtr<HTMLOptionsCollection> HTMLOptionsCollection::create(ContainerNode& select, CollectionType)
 {
     return adoptRef(new HTMLOptionsCollection(select));
 }
 
 void HTMLOptionsCollection::add(PassRefPtr<HTMLOptionElement> element, ExceptionState& exceptionState)
 {
     add(element, length(), exceptionState);
 }
 
 void HTMLOptionsCollection::add(PassRefPtr<HTMLOptionElement> element, int index, ExceptionState& exceptionState)
@@ skipping 70 matching lines @@
     if (!value) { // undefined or null
         base.remove(index);
         return true;
     }
     base.setOption(index, value.get(), exceptionState);
     return true;
 }
 
 } //namespace