Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: Source/core/dom/ClassCollection.h

Issue 176933013: Pass rootNode by reference when constructing node lists / collections (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/ChildNodeList.cpp ('k') | Source/core/dom/ClassCollection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/ClassCollection.h
diff --git a/Source/core/dom/ClassCollection.h b/Source/core/dom/ClassCollection.h
index a906537e0390c11c608d219bfb46e4ab8e59fdde..257cbb3b837b2d151d8eedf559cdf9c269254401 100644
--- a/Source/core/dom/ClassCollection.h
+++ b/Source/core/dom/ClassCollection.h
@@ -40,7 +40,7 @@ class ClassCollection FINAL : public HTMLCollection {
public:
// classNames argument is an AtomicString because it is common for Elements to share the same class names.
// It is also used to construct a SpaceSplitString (m_classNames) and its constructor requires an AtomicString.
- static PassRefPtr<ClassCollection> create(ContainerNode* rootNode, CollectionType type, const AtomicString& classNames)
+ static PassRefPtr<ClassCollection> create(ContainerNode& rootNode, CollectionType type, const AtomicString& classNames)
{
ASSERT_UNUSED(type, type == ClassCollectionType);
return adoptRef(new ClassCollection(rootNode, classNames));
@@ -51,7 +51,7 @@ public:
bool elementMatches(const Element&) const;
private:
- ClassCollection(ContainerNode* rootNode, const AtomicString& classNames);
+ ClassCollection(ContainerNode& rootNode, const AtomicString& classNames);
SpaceSplitString m_classNames;
AtomicString m_originalClassNames;
« no previous file with comments | « Source/core/dom/ChildNodeList.cpp ('k') | Source/core/dom/ClassCollection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698