Source/core/dom/Node.cpp - Issue 176933013: Pass rootNode by reference when constructing node lists / collections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Node.cpp

Issue 176933013: Pass rootNode by reference when constructing node lists / collections (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Node.cpp

diff --git a/Source/core/dom/Node.cpp b/Source/core/dom/Node.cpp

index bcd4ca3091f1dfe831cbe81c8a757c06a2f115c7..92ec953056d098ed231549d7545403ed47bd23a5 100644

--- a/Source/core/dom/Node.cpp

+++ b/Source/core/dom/Node.cpp

@@ -358,8 +358,8 @@ void Node::setNodeValue(const String&)

PassRefPtr<NodeList> Node::childNodes()

{

if (isContainerNode())

- return ensureRareData().ensureNodeLists().ensureChildNodeList(toContainerNode(this));

- return ensureRareData().ensureNodeLists().ensureEmptyChildNodeList(this);

+ return ensureRareData().ensureNodeLists().ensureChildNodeList(toContainerNode(*this));

+ return ensureRareData().ensureNodeLists().ensureEmptyChildNodeList(*this);

}

Node& Node::lastDescendant() const

« no previous file with comments | « Source/core/dom/NameNodeList.cpp ('k') | Source/core/dom/NodeRareData.h » ('j') | no next file with comments »