Source/core/dom/TagCollection.cpp - Issue 176933013: Pass rootNode by reference when constructing node lists / collections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/TagCollection.cpp

Issue 176933013: Pass rootNode by reference when constructing node lists / collections (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/TagCollection.cpp

diff --git a/Source/core/dom/TagCollection.cpp b/Source/core/dom/TagCollection.cpp

index 3a20c24b8b981ff724ba8d83f381f9c6e4524e6a..98bd3e4e3dd122d24742d270b36d5453819e6625 100644

--- a/Source/core/dom/TagCollection.cpp

+++ b/Source/core/dom/TagCollection.cpp

@@ -29,7 +29,7 @@

namespace WebCore {

-TagCollection::TagCollection(ContainerNode* rootNode, CollectionType type, const AtomicString& namespaceURI, const AtomicString& localName)

+TagCollection::TagCollection(ContainerNode& rootNode, CollectionType type, const AtomicString& namespaceURI, const AtomicString& localName)

: HTMLCollection(rootNode, type, DoesNotOverrideItemAfter)

, m_namespaceURI(namespaceURI)

, m_localName(localName)

@@ -54,7 +54,7 @@ bool TagCollection::elementMatches(const Element& testNode) const

return m_namespaceURI == starAtom || m_namespaceURI == testNode.namespaceURI();

}

-HTMLTagCollection::HTMLTagCollection(ContainerNode* rootNode, const AtomicString& localName)

+HTMLTagCollection::HTMLTagCollection(ContainerNode& rootNode, const AtomicString& localName)

: TagCollection(rootNode, HTMLTagCollectionType, starAtom, localName)

, m_loweredLocalName(localName.lower())

{

« no previous file with comments | « Source/core/dom/TagCollection.h ('k') | Source/core/html/HTMLAllCollection.h » ('j') | no next file with comments »