Use a non-deprecated method to get a string from an OSStatus error .

Use a non-deprecated method to get a string from an OSStatus error.

The functions GetMacOSStatusErrorString() and GetMacOSStatusCommentString() have
been deprecated since OSX 10.8. The official replacement is NSError.

BUG=547071
Committed: https://crrev.com/83e8f856e711121c3b196726877450fbbbec0761
Cr-Commit-Position: refs/heads/master@{#378564}

[erikchen, 2016-02-29 22:51:55]

Description was changed from

==========
Use a non-deprecated method to get a string from an OSStatus error .

The functions GetMacOSStatusErrorString() and GetMacOSStatusCommentString() have
been deprecated since OSX 10.8. The official replacement is NSError.

BUG=547071
==========

to

==========
Use a non-deprecated method to get a string from an OSStatus error.

The functions GetMacOSStatusErrorString() and GetMacOSStatusCommentString() have
been deprecated since OSX 10.8. The official replacement is NSError.

BUG=547071
==========

[erikchen, 2016-02-29 22:53:48]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-29 22:54:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1753523002/2
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1753523002/2

[commit-bot: I haz the power, 2016-02-29 23:08:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 23:08:09]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[erikchen, 2016-02-29 23:25:58]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-29 23:26:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1753523002/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1753523002/30001

[commit-bot: I haz the power, 2016-03-01 01:21:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 01:21:34]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-03-01 01:51:34]

erikchen@chromium.org changed reviewers:
+ mark@chromium.org, sergeyu@chromium.org, tommi@chromium.org

[erikchen, 2016-03-01 01:51:35]

mark: Please review base/
tommi: Please review media/audio/ and third_party/webrtc_overrides/
sergeyu: Please review remoting/

[tommi (sloooow) - chröme, 2016-03-01 09:24:55]

lgtm

[Mark Mentovai, 2016-03-01 15:27:24]

LGTM with a question that may or may not turn into a small change.

https://codereview.chromium.org/1753523002/diff/30001/base/mac/mac_logging.mm
File base/mac/mac_logging.mm (right):

https://codereview.chromium.org/1753523002/diff/30001/base/mac/mac_logging.mm...
base/mac/mac_logging.mm:22: return error.description.UTF8String;
Is the full -description what we want, or do we want -localizedDescription? How
does what this produces now compare to what we were getting before from
GetMacOSStatusErrorString()?

[erikchen, 2016-03-01 18:02:01]

https://codereview.chromium.org/1753523002/diff/30001/base/mac/mac_logging.mm
File base/mac/mac_logging.mm (right):

https://codereview.chromium.org/1753523002/diff/30001/base/mac/mac_logging.mm...
base/mac/mac_logging.mm:22: return error.description.UTF8String;
On 2016/03/01 15:27:23, Mark Mentovai wrote:
> Is the full -description what we want, or do we want -localizedDescription?
How
> does what this produces now compare to what we were getting before from
> GetMacOSStatusErrorString()?

We want -description.

-description: Error Domain=NSOSStatusErrorDomain Code=-42 tmfoErr: too many
files open
-localizedDescription: The operation couldn't be completed. (OSStatus error
-42.)
GetMacOSStatusErrorString: tmfoErr

[erikchen, 2016-03-01 18:04:48]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-03-01 18:05:01]

The CQ bit was unchecked by erikchen@chromium.org

[Sergey Ulanov, 2016-03-01 19:26:24]

lgtm

[Mark Mentovai, 2016-03-01 19:40:34]

erikchen wrote:
> https://codereview.chromium.org/1753523002/diff/30001/base/mac/mac_logging.mm
> File base/mac/mac_logging.mm (right):
> 
>
https://codereview.chromium.org/1753523002/diff/30001/base/mac/mac_logging.mm...
> base/mac/mac_logging.mm:22: return error.description.UTF8String;
> On 2016/03/01 15:27:23, Mark Mentovai wrote:
> > Is the full -description what we want, or do we want -localizedDescription?
> How
> > does what this produces now compare to what we were getting before from
> > GetMacOSStatusErrorString()?
> 
> We want -description.
> 
> -description: Error Domain=NSOSStatusErrorDomain Code=-42 tmfoErr: too many
> files open
> -localizedDescription: The operation couldn't be completed. (OSStatus error
> -42.)
> GetMacOSStatusErrorString: tmfoErr

Very well, still LG.

[erikchen, 2016-03-01 21:22:37]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-03-01 21:23:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1753523002/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1753523002/30001

[commit-bot: I haz the power, 2016-03-01 21:38:33]

Committed patchset #3 (id:30001)

[commit-bot: I haz the power, 2016-03-01 21:40:19]

Description was changed from

==========
Use a non-deprecated method to get a string from an OSStatus error.

The functions GetMacOSStatusErrorString() and GetMacOSStatusCommentString() have
been deprecated since OSX 10.8. The official replacement is NSError.

BUG=547071
==========

to

==========
Use a non-deprecated method to get a string from an OSStatus error.

The functions GetMacOSStatusErrorString() and GetMacOSStatusCommentString() have
been deprecated since OSX 10.8. The official replacement is NSError.

BUG=547071

Committed: https://crrev.com/83e8f856e711121c3b196726877450fbbbec0761
Cr-Commit-Position: refs/heads/master@{#378564}
==========

[commit-bot: I haz the power, 2016-03-01 21:40:20]

Patchset 3 (id:??) landed as
https://crrev.com/83e8f856e711121c3b196726877450fbbbec0761
Cr-Commit-Position: refs/heads/master@{#378564}