Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/webrtc_overrides/webrtc/base/logging.cc

Issue 1753523002: Use a non-deprecated method to get a string from an OSStatus error . (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/mac/mac_logging.mm ('K') | « remoting/host/mac/me2me_preference_pane.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/webrtc_overrides/webrtc/base/logging.cc
diff --git a/third_party/webrtc_overrides/webrtc/base/logging.cc b/third_party/webrtc_overrides/webrtc/base/logging.cc
index 2ac9ee9856af6b5608fcfe07489e3f2606d57bae..db888c1a4ad2c43c0cb526d3859dbab90ee43a01 100644
--- a/third_party/webrtc_overrides/webrtc/base/logging.cc
+++ b/third_party/webrtc_overrides/webrtc/base/logging.cc
@@ -25,6 +25,10 @@
#include "third_party/webrtc_overrides/webrtc/base/diagnostic_logging.h"
#include "third_party/webrtc_overrides/webrtc/base/logging.h"
+#if defined(WEBRTC_MAC)
+#include "base/mac/mac_logging.h"
+#endif
+
// From this file we can't use VLOG since it expands into usage of the __FILE__
// macro (for correct filtering). The actual logging call from DIAGNOSTIC_LOG in
// ~DiagnosticLogMessage. Note that the second parameter to the LAZY_STREAM
@@ -148,11 +152,7 @@ static void LogExtra(std::ostringstream* print_stream,
break;
#elif defined(WEBRTC_MAC)
case ERRCTX_OSSTATUS: {
- (*print_stream) << " " << nonnull(GetMacOSStatusErrorString(err),
- "Unknown error");
- if (const char* desc = GetMacOSStatusCommentString(err)) {
- (*print_stream) << ": " << desc;
- }
+ (*print_stream) << " " << logging::DescriptionFromOSStatus(err);
break;
}
#endif // defined(WEBRTC_WIN)
« base/mac/mac_logging.mm ('K') | « remoting/host/mac/me2me_preference_pane.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698