Suppress the clang warning "-Wdeprecated-declarations" for CSSM API calls.

Suppress the clang warning "-Wdeprecated-declarations" for CSSM API calls.

The CSSM API has been deprecated since OSX 10.7, but there is no replacement.

BUG=590914
Committed: https://crrev.com/bedc26167ab5402cf9e4a51afeeeb90ababb9da0
Cr-Commit-Position: refs/heads/master@{#378668}

[erikchen, 2016-03-01 00:59:42]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 01:00:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1753553002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1753553002/1

[commit-bot: I haz the power, 2016-03-01 01:17:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 01:17:58]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[erikchen, 2016-03-01 02:08:18]

erikchen@chromium.org changed reviewers:
+ mark@chromium.org, rsleevi@chromium.org

[erikchen, 2016-03-01 02:08:19]

rsleevi: Please review net/ and crypto/
mark: Please review third_party/apple_apsl

[Mark Mentovai, 2016-03-01 15:22:59]

LGTM in third_party

[Ryan Sleevi, 2016-03-01 15:59:58]

LGTM % 1 nit

https://codereview.chromium.org/1753553002/diff/1/crypto/cssm_init.h
File crypto/cssm_init.h (right):

https://codereview.chromium.org/1753553002/diff/1/crypto/cssm_init.h#newcode49
crypto/cssm_init.h:49: // CSSM functions are deprecated as of OSX 10.7, but have
no replacement.
A newline between 48/49 would be helpful for readability.

More generally, though, why doesn't this deprecation wrapping need to be moved
to line 19/20? The CSSM_CSP_HANDLE / CSSM_API_MEMORY_FUNCS / CSSM_RETURN are all
part of the same deprecated state. I'm assuming it's because OS X doesn't
support deprecating typedefs?

[erikchen, 2016-03-02 02:02:59]

https://codereview.chromium.org/1753553002/diff/1/crypto/cssm_init.h
File crypto/cssm_init.h (right):

https://codereview.chromium.org/1753553002/diff/1/crypto/cssm_init.h#newcode49
crypto/cssm_init.h:49: // CSSM functions are deprecated as of OSX 10.7, but have
no replacement.
On 2016/03/01 15:59:58, Ryan Sleevi wrote:
> A newline between 48/49 would be helpful for readability.
> 
> More generally, though, why doesn't this deprecation wrapping need to be moved
> to line 19/20? The CSSM_CSP_HANDLE / CSSM_API_MEMORY_FUNCS / CSSM_RETURN are
all
> part of the same deprecated state. I'm assuming it's because OS X doesn't
> support deprecating typedefs?

It looks like C++14 introduces a deprecated attribute, which Clang has already
implemented. I wouldn't be surprised if Apple deprecated the typedefs sometime
in the future.
http://josephmansfield.uk/articles/marking-deprecated-c++14.html

I went ahead and moved the wrapping to line 14, which includes one extra
function, but happens to be immediately after a namespace declaration. I also
moved the #pragma pop right before the end of the namespace scope. This seems
cleaner to me. (Given that the scope of the #clang diagnostics is entirely
independent of C++ semantic scoping, it still seems reasonable to attempt to
match the two together).

[erikchen, 2016-03-02 02:03:05]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-03-02 02:03:05]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/1753553002/#ps40001
(title: "nits")

[commit-bot: I haz the power, 2016-03-02 02:03:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1753553002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1753553002/40001

[commit-bot: I haz the power, 2016-03-02 02:52:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-02 02:53:11]

Description was changed from

==========
Suppress the clang warning "-Wdeprecated-declarations" for CSSM API calls.

The CSSM API has been deprecated since OSX 10.7, but there is no replacement.

BUG=590914
==========

to

==========
Suppress the clang warning "-Wdeprecated-declarations" for CSSM API calls.

The CSSM API has been deprecated since OSX 10.7, but there is no replacement.

BUG=590914

Committed: https://crrev.com/bedc26167ab5402cf9e4a51afeeeb90ababb9da0
Cr-Commit-Position: refs/heads/master@{#378668}
==========

[commit-bot: I haz the power, 2016-03-02 02:53:12]

Patchset 3 (id:??) landed as
https://crrev.com/bedc26167ab5402cf9e4a51afeeeb90ababb9da0
Cr-Commit-Position: refs/heads/master@{#378668}