Ignore deprecated declaration warnings in GTM.

Ignore deprecated declaration warnings in GTM.

GTM supports ancient iOS and OSX versions, so it's full of APIs that have been
deprecated in more recent iOS and OSX versions. Ignore all deprecated
declaration warnings.

BUG=547071
Committed: https://crrev.com/911d21a2392ead090e2c4bbe3fb3285546865d7b
Cr-Commit-Position: refs/heads/master@{#378539}

[erikchen, 2016-02-29 22:22:52]

erikchen@chromium.org changed reviewers:
+ mark@chromium.org

[erikchen, 2016-02-29 22:22:52]

mark: Please review.

[erikchen, 2016-03-01 00:24:00]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 00:24:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1752513002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1752513002/1

[commit-bot: I haz the power, 2016-03-01 01:48:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 01:48:52]

Dry run: This issue passed the CQ dry run.

[Mark Mentovai, 2016-03-01 19:41:26]

LGTM

[erikchen, 2016-03-01 19:58:06]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-03-01 19:58:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1752513002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1752513002/1

[commit-bot: I haz the power, 2016-03-01 20:04:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-01 20:05:35]

Description was changed from

==========
Ignore deprecated declaration warnings in GTM.

GTM supports ancient iOS and OSX versions, so it's full of APIs that have been
deprecated in more recent iOS and OSX versions. Ignore all deprecated
declaration warnings.

BUG=547071
==========

to

==========
Ignore deprecated declaration warnings in GTM.

GTM supports ancient iOS and OSX versions, so it's full of APIs that have been
deprecated in more recent iOS and OSX versions. Ignore all deprecated
declaration warnings.

BUG=547071

Committed: https://crrev.com/911d21a2392ead090e2c4bbe3fb3285546865d7b
Cr-Commit-Position: refs/heads/master@{#378539}
==========

[commit-bot: I haz the power, 2016-03-01 20:05:36]

Patchset 1 (id:??) landed as
https://crrev.com/911d21a2392ead090e2c4bbe3fb3285546865d7b
Cr-Commit-Position: refs/heads/master@{#378539}

[Nico, 2016-03-30 12:46:34]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-03-30 12:46:35]

I don't think that's the right fix. When moving from 10.5 to 10.6, we fixed the
warnings in GTM. We should do this again.

In general, adding -Wno-deprecated-declarations is almost never the right fix.

[erikchen, 2016-03-30 18:56:38]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1849533003/ by erikchen@chromium.org.

The reason for reverting is: Reverting patchset as requested by thakis@.

"""
I don't think that's the right fix. When moving from 10.5 to 10.6, we fixed the
warnings in GTM. We should do this again.

In general, adding -Wno-deprecated-declarations is almost never the right fix.
""".