Use a non-deprecated method to get a string from an OSStatus error .

base/mac/mac_logging.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/mac/mac_logging.h"
-#include "build/build_config.h"
+
+#import <Foundation/Foundation.h>
 
 #include <iomanip>
 
+#include "build/build_config.h"
+
 #if !defined(OS_IOS)
 #include <CoreServices/CoreServices.h>
 #endif
 
 namespace logging {
 
+std::string DescriptionFromOSStatus(OSStatus err) {
+  NSError* error =
+      [NSError errorWithDomain:NSOSStatusErrorDomain code:err userInfo:nil];
+  return error.description.UTF8String;

[Mark Mentovai, 2016/03/01 15:27:23]

Is the full -description what we want, or do we want -localizedDescription? How
does what this produces now compare to what we were getting before from
GetMacOSStatusErrorString()?

[erikchen, 2016/03/01 18:02:00]

We want -description.

-description: Error Domain=NSOSStatusErrorDomain Code=-42 tmfoErr: too many
files open
-localizedDescription: The operation couldn't be completed. (OSStatus error
-42.)
GetMacOSStatusErrorString: tmfoErr

+}
+
 OSStatusLogMessage::OSStatusLogMessage(const char* file_path,
                                        int line,
                                        LogSeverity severity,
                                        OSStatus status)
     : LogMessage(file_path, line, severity),
       status_(status) {
 }
 
 OSStatusLogMessage::~OSStatusLogMessage() {
 #if defined(OS_IOS)
   // TODO(ios): Consider using NSError with NSOSStatusErrorDomain to try to
   // get a description of the failure.
   stream() << ": " << status_;
 #else
   stream() << ": "
-           << GetMacOSStatusErrorString(status_)
+           << DescriptionFromOSStatus(status_)
            << " ("
            << status_
            << ")";
 #endif
 }
 
 }  // namespace logging