Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1752383004: CREDENTIAL: Serialize 'PasswordCredential' objects with "" as the federation. (Closed)

Created:
4 years, 9 months ago by Mike West
Modified:
4 years, 9 months ago
Reviewers:
vasilii
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

CREDENTIAL: Serialize 'PasswordCredential' objects with "" as the federation. After https://codereview.chromium.org/1723583004, we serialize `PasswordCredential` objects with a `federation_url` of "null" (as "null" is the serialization of an empty/unique origin. Neither Android nor Vasilii like this. This patch special-cases things to ensure that Android (and Vasilii) remains as happy as can be. BUG=591310 R=vasilii@chromium.org Review URL: https://codereview.chromium.org/1755053002 Cr-Commit-Position: refs/heads/master@{#378734} (cherry picked from commit 45bf9a3d72344f1b7a6f28e0bc1c5536339db4a8) Committed: https://chromium.googlesource.com/chromium/src/+/0e8fd0d85b3174359835662c3dbd9f3059120729

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M chrome/browser/password_manager/native_backend_gnome_x.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/password_manager/native_backend_gnome_x_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/password_manager/native_backend_kwallet_x.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/password_manager/native_backend_libsecret.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/password_manager/native_backend_libsecret_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M components/password_manager/core/browser/login_database.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Mike West
4 years, 9 months ago (2016-03-03 09:09:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0e8fd0d85b3174359835662c3dbd9f3059120729.

Powered by Google App Engine
This is Rietveld 408576698