chrome/browser/password_manager/native_backend_kwallet_x.cc - Issue 1752383004: CREDENTIAL: Serialize 'PasswordCredential' objects with "" as the federation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_kwallet_x.cc

Issue 1752383004: CREDENTIAL: Serialize 'PasswordCredential' objects with "" as the federation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/native_backend_gnome_x_unittest.cc ('k') | chrome/browser/password_manager/native_backend_libsecret.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/native_backend_kwallet_x.cc

diff --git a/chrome/browser/password_manager/native_backend_kwallet_x.cc b/chrome/browser/password_manager/native_backend_kwallet_x.cc

index 072ccad7bb67c2a97e59049d4c80a32839adc98b..d696d53667f431459bed4e1eb24da22fbadd0ddd 100644

--- a/chrome/browser/password_manager/native_backend_kwallet_x.cc

+++ b/chrome/browser/password_manager/native_backend_kwallet_x.cc

@@ -277,7 +277,11 @@ void SerializeValue(const std::vector<autofill::PasswordForm*>& forms,

pickle->WriteInt64(form->date_synced.ToInternalValue());

pickle->WriteString16(form->display_name);

pickle->WriteString(form->icon_url.spec());

- pickle->WriteString(form->federation_origin.Serialize());

+ // We serialize unique origins as "", in order to make other systems that

+ // read from the login database happy. https://crbug.com/591310

+ pickle->WriteString(form->federation_origin.unique()

+ ? std::string()

+ : form->federation_origin.Serialize());

pickle->WriteBool(form->skip_zero_click);

pickle->WriteInt(form->generation_upload_status);

}