chrome/browser/password_manager/native_backend_libsecret.cc - Issue 1752383004: CREDENTIAL: Serialize 'PasswordCredential' objects with "" as the federation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_libsecret.cc

Issue 1752383004: CREDENTIAL: Serialize 'PasswordCredential' objects with "" as the federation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/native_backend_kwallet_x.cc ('k') | chrome/browser/password_manager/native_backend_libsecret_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/native_backend_libsecret.cc

diff --git a/chrome/browser/password_manager/native_backend_libsecret.cc b/chrome/browser/password_manager/native_backend_libsecret.cc

index 87e256e711e9feaba0364f05c94a66d58d7e9ae4..8c65356485550e6a6d6bab1d363641fa883c70f7 100644

--- a/chrome/browser/password_manager/native_backend_libsecret.cc

+++ b/chrome/browser/password_manager/native_backend_libsecret.cc

@@ -495,7 +495,11 @@ bool NativeBackendLibsecret::RawAddLogin(const PasswordForm& form) {

"date_synced", base::Int64ToString(date_synced).c_str(),

"display_name", UTF16ToUTF8(form.display_name).c_str(),

"avatar_url", form.icon_url.spec().c_str(),

- "federation_url", form.federation_origin.Serialize().c_str(),

+ // We serialize unique origins as "", in order to make other systems that

+ // read from the login database happy. https://crbug.com/591310

+ "federation_url", form.federation_origin.unique()

+ ? ""

+ : form.federation_origin.Serialize().c_str(),

"should_skip_zero_click", form.skip_zero_click,

"generation_upload_status", form.generation_upload_status,

"form_data", form_data.c_str(),