CREDENTIAL: Serialize 'PasswordCredential' objects with "" as the federation.

CREDENTIAL: Serialize 'PasswordCredential' objects with "" as the federation.

After https://codereview.chromium.org/1723583004, we serialize
`PasswordCredential` objects with a `federation_url` of "null" (as "null" is
the serialization of an empty/unique origin.

Neither Android nor Vasilii like this. This patch special-cases things to
ensure that Android (and Vasilii) remains as happy as can be.

BUG=591310
R=vasilii@chromium.org

Committed: https://crrev.com/45bf9a3d72344f1b7a6f28e0bc1c5536339db4a8
Cr-Commit-Position: refs/heads/master@{#378734}

[Mike West, 2016-03-02 09:50:17]

WDYT, Vasilii?

[vasilii, 2016-03-02 11:45:00]

Not only Android. I also don't like "null".

https://codereview.chromium.org/1755053002/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/native_backend_kwallet_x.cc (right):

https://codereview.chromium.org/1755053002/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/native_backend_kwallet_x.cc:283: ? ""
string()

https://codereview.chromium.org/1755053002/diff/1/components/password_manager...
File components/password_manager/core/browser/login_database.cc (right):

https://codereview.chromium.org/1755053002/diff/1/components/password_manager...
components/password_manager/core/browser/login_database.cc:947: ? ""
std::string()

[vasilii, 2016-03-02 11:45:16]

LGTM with nits.

[Mike West, 2016-03-02 12:06:06]

Description was changed from

==========
CREDENTIAL: Serialize 'PasswordCredential' objects with "" as the federation.

After https://codereview.chromium.org/1723583004, we serialize
`PasswordCredential` objects with a `federation_url` of "null" (as "null" is
the serialization of an empty/unique origin.

Android doesn't like this. This patch special-cases things to ensure that
Android remains as happy as can be.

BUG=591310
R=vasilii@chromium.org
==========

to

==========
CREDENTIAL: Serialize 'PasswordCredential' objects with "" as the federation.

After https://codereview.chromium.org/1723583004, we serialize
`PasswordCredential` objects with a `federation_url` of "null" (as "null" is
the serialization of an empty/unique origin.

Neither Android nor Vasilii like this. This patch special-cases things to
ensure that Android (and Vasilii) remains as happy as can be.

BUG=591310
R=vasilii@chromium.org
==========

[Mike West, 2016-03-02 12:06:36]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2016-03-02 12:06:36]

The patchset sent to the CQ was uploaded after l-g-t-m from vasilii@chromium.org
Link to the patchset: https://codereview.chromium.org/1755053002/#ps20001
(title: "vasilii")

[commit-bot: I haz the power, 2016-03-02 12:06:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1755053002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1755053002/20001

[Mike West, 2016-03-02 12:07:10]

On 2016/03/02 at 11:45:16, vasilii wrote:
> LGTM with nits.

Thanks. Updated CL description and took care of the nits.

[commit-bot: I haz the power, 2016-03-02 12:57:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-02 12:59:07]

Description was changed from

==========
CREDENTIAL: Serialize 'PasswordCredential' objects with "" as the federation.

After https://codereview.chromium.org/1723583004, we serialize
`PasswordCredential` objects with a `federation_url` of "null" (as "null" is
the serialization of an empty/unique origin.

Neither Android nor Vasilii like this. This patch special-cases things to
ensure that Android (and Vasilii) remains as happy as can be.

BUG=591310
R=vasilii@chromium.org
==========

to

==========
CREDENTIAL: Serialize 'PasswordCredential' objects with "" as the federation.

After https://codereview.chromium.org/1723583004, we serialize
`PasswordCredential` objects with a `federation_url` of "null" (as "null" is
the serialization of an empty/unique origin.

Neither Android nor Vasilii like this. This patch special-cases things to
ensure that Android (and Vasilii) remains as happy as can be.

BUG=591310
R=vasilii@chromium.org

Committed: https://crrev.com/45bf9a3d72344f1b7a6f28e0bc1c5536339db4a8
Cr-Commit-Position: refs/heads/master@{#378734}
==========

[commit-bot: I haz the power, 2016-03-02 12:59:08]

Patchset 2 (id:??) landed as
https://crrev.com/45bf9a3d72344f1b7a6f28e0bc1c5536339db4a8
Cr-Commit-Position: refs/heads/master@{#378734}