Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Side by Side Diff: chrome/browser/password_manager/native_backend_libsecret.cc

Issue 1752383004: CREDENTIAL: Serialize 'PasswordCredential' objects with "" as the federation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/native_backend_libsecret.h" 5 #include "chrome/browser/password_manager/native_backend_libsecret.h"
6 6
7 #include <dlfcn.h> 7 #include <dlfcn.h>
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 477 matching lines...) Expand 10 before | Expand all | Expand 10 after
488 "ssl_valid", form.ssl_valid, 488 "ssl_valid", form.ssl_valid,
489 "preferred", form.preferred, 489 "preferred", form.preferred,
490 "date_created", base::Int64ToString(date_created).c_str(), 490 "date_created", base::Int64ToString(date_created).c_str(),
491 "blacklisted_by_user", form.blacklisted_by_user, 491 "blacklisted_by_user", form.blacklisted_by_user,
492 "type", form.type, 492 "type", form.type,
493 "times_used", form.times_used, 493 "times_used", form.times_used,
494 "scheme", form.scheme, 494 "scheme", form.scheme,
495 "date_synced", base::Int64ToString(date_synced).c_str(), 495 "date_synced", base::Int64ToString(date_synced).c_str(),
496 "display_name", UTF16ToUTF8(form.display_name).c_str(), 496 "display_name", UTF16ToUTF8(form.display_name).c_str(),
497 "avatar_url", form.icon_url.spec().c_str(), 497 "avatar_url", form.icon_url.spec().c_str(),
498 "federation_url", form.federation_origin.Serialize().c_str(), 498 // We serialize unique origins as "", in order to make other systems that
499 // read from the login database happy. https://crbug.com/591310
500 "federation_url", form.federation_origin.unique()
501 ? ""
502 : form.federation_origin.Serialize().c_str(),
499 "should_skip_zero_click", form.skip_zero_click, 503 "should_skip_zero_click", form.skip_zero_click,
500 "generation_upload_status", form.generation_upload_status, 504 "generation_upload_status", form.generation_upload_status,
501 "form_data", form_data.c_str(), 505 "form_data", form_data.c_str(),
502 "application", app_string_.c_str(), 506 "application", app_string_.c_str(),
503 nullptr); 507 nullptr);
504 // clang-format on 508 // clang-format on
505 509
506 if (error) { 510 if (error) {
507 LOG(ERROR) << "Libsecret add raw login failed: " << error->message; 511 LOG(ERROR) << "Libsecret add raw login failed: " << error->message;
508 g_error_free(error); 512 g_error_free(error);
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
672 UMA_HISTOGRAM_ENUMERATION( 676 UMA_HISTOGRAM_ENUMERATION(
673 "PasswordManager.PslDomainMatchTriggering", 677 "PasswordManager.PslDomainMatchTriggering",
674 password_manager::ShouldPSLDomainMatchingApply(registered_domain) 678 password_manager::ShouldPSLDomainMatchingApply(registered_domain)
675 ? psl_domain_match_metric 679 ? psl_domain_match_metric
676 : password_manager::PSL_DOMAIN_MATCH_NOT_USED, 680 : password_manager::PSL_DOMAIN_MATCH_NOT_USED,
677 password_manager::PSL_DOMAIN_MATCH_COUNT); 681 password_manager::PSL_DOMAIN_MATCH_COUNT);
678 } 682 }
679 g_list_free(found); 683 g_list_free(found);
680 return forms; 684 return forms;
681 } 685 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698