Minor cleanup to remove the static thread-safe methods on BrowserMainLoop. Initially I thought this…

Minor cleanup to remove the static thread-safe methods on BrowserMainLoop. Initially I thought this would be one getter so it seemed fine, but now it has 3 and more are on the way. Switch to one static getter for this class, and then getters for the member variables. I used dependency injection to allow access to these objects from other threads, which also cleaned up tests a bit.

R=scherkus@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207871

[scherkus (not reviewing), 2013-06-21 00:42:43]

lgtm w/ nits

https://codereview.chromium.org/17508005/diff/1/content/browser/media_devices...
File content/browser/media_devices_monitor.cc (right):

https://codereview.chromium.org/17508005/diff/1/content/browser/media_devices...
content/browser/media_devices_monitor.cc:15: // Post a EnumerateDevices() API to
MSM to start the monitoring.
comment is incorrect

https://codereview.chromium.org/17508005/diff/1/content/browser/media_devices...
content/browser/media_devices_monitor.cc:26:
base::Bind(&EnsureMonitorCaptureDevicesInternal,
I guess we could replace EnsureMonitorCaptureDevicesInternal() by beefing up the
base::Bind()

base::Bind(&MediaStreamManager::EnumerateDevices,
BrowserMainLoop::GetInstance()->media_stream_manager(), NULL, -1, -1,
MEDIA_DEVICE_AUDIO_CAPTURE, GURL())

[jam, 2013-06-21 15:38:58]

https://codereview.chromium.org/17508005/diff/1/content/browser/media_devices...
File content/browser/media_devices_monitor.cc (right):

https://codereview.chromium.org/17508005/diff/1/content/browser/media_devices...
content/browser/media_devices_monitor.cc:15: // Post a EnumerateDevices() API to
MSM to start the monitoring.
On 2013/06/21 00:42:43, scherkus wrote:
> comment is incorrect

that's what it was before?

https://codereview.chromium.org/17508005/diff/1/content/browser/media_devices...
content/browser/media_devices_monitor.cc:26:
base::Bind(&EnsureMonitorCaptureDevicesInternal,
On 2013/06/21 00:42:43, scherkus wrote:
> I guess we could replace EnsureMonitorCaptureDevicesInternal() by beefing up
the
> base::Bind()
> 
> base::Bind(&MediaStreamManager::EnumerateDevices,
> BrowserMainLoop::GetInstance()->media_stream_manager(), NULL, -1, -1,
> MEDIA_DEVICE_AUDIO_CAPTURE, GURL())

Done. it ended up looking not so pretty though because of bind quirks (i.e.
needed a MediaStreamRequester pointer instead of NULL because it couldn't deduce
its type, ignoreresult, unretained), let me know if you want to change it back.

[scherkus (not reviewing), 2013-06-21 16:18:42]

lgtm+++

https://codereview.chromium.org/17508005/diff/1/content/browser/media_devices...
File content/browser/media_devices_monitor.cc (right):

https://codereview.chromium.org/17508005/diff/1/content/browser/media_devices...
content/browser/media_devices_monitor.cc:15: // Post a EnumerateDevices() API to
MSM to start the monitoring.
On 2013/06/21 15:38:58, jam wrote:
> On 2013/06/21 00:42:43, scherkus wrote:
> > comment is incorrect
> 
> that's what it was before?

oh I was referring to the "post to start" -- that bit is now accomplished below
where we call PostTask :)

https://codereview.chromium.org/17508005/diff/25001/content/browser/media_dev...
File content/browser/media_devices_monitor.cc (right):

https://codereview.chromium.org/17508005/diff/25001/content/browser/media_dev...
content/browser/media_devices_monitor.cc:21:
base::Bind(base::IgnoreResult(&MediaStreamManager::EnumerateDevices),
oh gross :(

yeah ... let's go back to the old method

sorry about that!

[jam, 2013-06-21 16:49:19]

https://codereview.chromium.org/17508005/diff/1/content/browser/media_devices...
File content/browser/media_devices_monitor.cc (right):

https://codereview.chromium.org/17508005/diff/1/content/browser/media_devices...
content/browser/media_devices_monitor.cc:15: // Post a EnumerateDevices() API to
MSM to start the monitoring.
On 2013/06/21 16:18:42, scherkus wrote:
> On 2013/06/21 15:38:58, jam wrote:
> > On 2013/06/21 00:42:43, scherkus wrote:
> > > comment is incorrect
> > 
> > that's what it was before?
> 
> oh I was referring to the "post to start" -- that bit is now accomplished
below
> where we call PostTask :)

what I meant was that that comment was there before in the posted method..
anyways i took out the comment, because it was just documenting the function
call below and so was useless

[scherkus (not reviewing), 2013-06-21 17:36:55]

even better!
On Jun 21, 2013 9:49 AM, <jam@chromium.org> wrote:

>
> https://codereview.chromium.**org/17508005/diff/1/content/**
>
browser/media_devices_monitor.**cc<https://codereview.chromium.org/17508005/diff/1/content/browser/media_devices_monitor.cc>
> File content/browser/media_devices_**monitor.cc (right):
>
> https://codereview.chromium.**org/17508005/diff/1/content/**
>
browser/media_devices_monitor.**cc#newcode15<https://codereview.chromium.org/17508005/diff/1/content/browser/media_devices_monitor.cc#newcode15>
> content/browser/media_devices_**monitor.cc:15: // Post a
> EnumerateDevices() API to MSM to start the monitoring.
> On 2013/06/21 16:18:42, scherkus wrote:
>
>> On 2013/06/21 15:38:58, jam wrote:
>> > On 2013/06/21 00:42:43, scherkus wrote:
>> > > comment is incorrect
>> >
>> > that's what it was before?
>>
>
>  oh I was referring to the "post to start" -- that bit is now
>>
> accomplished below
>
>> where we call PostTask :)
>>
>
> what I meant was that that comment was there before in the posted
> method.. anyways i took out the comment, because it was just documenting
> the function call below and so was useless
>
>
https://codereview.chromium.**org/17508005/<https://codereview.chromium.org/1...
>