Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: content/browser/renderer_host/media/web_contents_audio_input_stream.h

Issue 17508005: Minor cleanup to remove the static thread-safe methods on BrowserMainLoop. Initially I thought this… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: revert PostTask change Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // An AudioInputStream which provides a loop-back of all audio output generated 5 // An AudioInputStream which provides a loop-back of all audio output generated
6 // by the RenderView associated with a WebContents instance. The single stream 6 // by the RenderView associated with a WebContents instance. The single stream
7 // of data is produced by format-converting and mixing all audio output from a 7 // of data is produced by format-converting and mixing all audio output from a
8 // RenderView. In other words, WebContentsAudioInputStream provides tab-level 8 // RenderView. In other words, WebContentsAudioInputStream provides tab-level
9 // audio mirroring. 9 // audio mirroring.
10 // 10 //
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 virtual bool GetAutomaticGainControl() OVERRIDE; 51 virtual bool GetAutomaticGainControl() OVERRIDE;
52 52
53 // Create a new audio mirroring session, or return NULL on error. |device_id| 53 // Create a new audio mirroring session, or return NULL on error. |device_id|
54 // should be in the format accepted by 54 // should be in the format accepted by
55 // WebContentsCaptureUtil::ExtractTabCaptureTarget(). The caller must 55 // WebContentsCaptureUtil::ExtractTabCaptureTarget(). The caller must
56 // guarantee Close() is called on the returned object so that it may 56 // guarantee Close() is called on the returned object so that it may
57 // self-destruct. 57 // self-destruct.
58 static WebContentsAudioInputStream* Create( 58 static WebContentsAudioInputStream* Create(
59 const std::string& device_id, 59 const std::string& device_id,
60 const media::AudioParameters& params, 60 const media::AudioParameters& params,
61 const scoped_refptr<base::MessageLoopProxy>& message_loop); 61 const scoped_refptr<base::MessageLoopProxy>& message_loop,
62 AudioMirroringManager* audio_mirroring_manager);
62 63
63 private: 64 private:
64 friend class WebContentsAudioInputStreamTest; 65 friend class WebContentsAudioInputStreamTest;
65 66
66 // Maintain most state and functionality in an internal ref-counted 67 // Maintain most state and functionality in an internal ref-counted
67 // implementation class. This object must outlive a call to Close(), until 68 // implementation class. This object must outlive a call to Close(), until
68 // the shutdown tasks running on other threads complete: The 69 // the shutdown tasks running on other threads complete: The
69 // AudioMirroringManager on the IO thread, the WebContentsTracker on the UI 70 // AudioMirroringManager on the IO thread, the WebContentsTracker on the UI
70 // thread, and the VirtualAudioOuputStreams on the audio thread. 71 // thread, and the VirtualAudioOuputStreams on the audio thread.
71 class Impl; 72 class Impl;
72 73
73 WebContentsAudioInputStream( 74 WebContentsAudioInputStream(
74 int render_process_id, int render_view_id, 75 int render_process_id, int render_view_id,
75 const scoped_refptr<base::MessageLoopProxy>& message_loop, 76 const scoped_refptr<base::MessageLoopProxy>& message_loop,
76 AudioMirroringManager* mirroring_manager, 77 AudioMirroringManager* mirroring_manager,
77 const scoped_refptr<WebContentsTracker>& tracker, 78 const scoped_refptr<WebContentsTracker>& tracker,
78 media::VirtualAudioInputStream* mixer_stream); 79 media::VirtualAudioInputStream* mixer_stream);
79 80
80 virtual ~WebContentsAudioInputStream(); 81 virtual ~WebContentsAudioInputStream();
81 82
82 scoped_refptr<Impl> impl_; 83 scoped_refptr<Impl> impl_;
83 84
84 DISALLOW_COPY_AND_ASSIGN(WebContentsAudioInputStream); 85 DISALLOW_COPY_AND_ASSIGN(WebContentsAudioInputStream);
85 }; 86 };
86 87
87 } // namespace content 88 } // namespace content
88 89
89 #endif // CONTENT_BROWSER_RENDERER_HOST_MEDIA_WEB_CONTENTS_AUDIO_INPUT_STREAM_H _ 90 #endif // CONTENT_BROWSER_RENDERER_HOST_MEDIA_WEB_CONTENTS_AUDIO_INPUT_STREAM_H _
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698