content/browser/renderer_host/media/web_contents_audio_input_stream.cc - Issue 17508005: Minor cleanup to remove the static thread-safe methods on BrowserMainLoop. Initially I thought this…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/web_contents_audio_input_stream.cc

Issue 17508005: Minor cleanup to remove the static thread-safe methods on BrowserMainLoop. Initially I thought this… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: revert PostTask change Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/web_contents_audio_input_stream.h ('k') | content/browser/renderer_host/render_message_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/web_contents_audio_input_stream.cc

===================================================================

--- content/browser/renderer_host/media/web_contents_audio_input_stream.cc (revision 207505)

+++ content/browser/renderer_host/media/web_contents_audio_input_stream.cc (working copy)

@@ -11,7 +11,6 @@

#include "base/logging.h"

#include "base/memory/scoped_ptr.h"

#include "base/message_loop/message_loop_proxy.h"

-#include "content/browser/browser_main_loop.h"

#include "content/browser/renderer_host/media/audio_mirroring_manager.h"

#include "content/browser/renderer_host/media/web_contents_capture_util.h"

#include "content/browser/renderer_host/media/web_contents_tracker.h"

@@ -281,7 +280,8 @@

WebContentsAudioInputStream* WebContentsAudioInputStream::Create(

const std::string& device_id,

const media::AudioParameters& params,

- const scoped_refptr<base::MessageLoopProxy>& message_loop) {

+ const scoped_refptr<base::MessageLoopProxy>& message_loop,

+ AudioMirroringManager* audio_mirroring_manager) {

int render_process_id;

int render_view_id;

if (!WebContentsCaptureUtil::ExtractTabCaptureTarget(

@@ -291,7 +291,7 @@

return new WebContentsAudioInputStream(

render_process_id, render_view_id, message_loop,

- BrowserMainLoop::GetAudioMirroringManager(),

+ audio_mirroring_manager,

new WebContentsTracker(),

new media::VirtualAudioInputStream(

params, message_loop,