Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: content/browser/renderer_host/media/video_capture_host_unittest.cc

Issue 17508005: Minor cleanup to remove the static thread-safe methods on BrowserMainLoop. Initially I thought this… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: revert PostTask change Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <map> 5 #include <map>
6 #include <string> 6 #include <string>
7 7
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/file_util.h" 9 #include "base/file_util.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 } 65 }
66 66
67 private: 67 private:
68 file_util::ScopedFILE file_; 68 file_util::ScopedFILE file_;
69 int expected_size_; 69 int expected_size_;
70 }; 70 };
71 71
72 class MockVideoCaptureHost : public VideoCaptureHost { 72 class MockVideoCaptureHost : public VideoCaptureHost {
73 public: 73 public:
74 MockVideoCaptureHost(MediaStreamManager* manager) 74 MockVideoCaptureHost(MediaStreamManager* manager)
75 : VideoCaptureHost(), 75 : VideoCaptureHost(manager),
76 return_buffers_(false), 76 return_buffers_(false),
77 dump_video_(false), 77 dump_video_(false) {}
78 manager_(manager) {}
79 78
80 // A list of mock methods. 79 // A list of mock methods.
81 MOCK_METHOD4(OnNewBufferCreated, 80 MOCK_METHOD4(OnNewBufferCreated,
82 void(int device_id, base::SharedMemoryHandle handle, 81 void(int device_id, base::SharedMemoryHandle handle,
83 int length, int buffer_id)); 82 int length, int buffer_id));
84 MOCK_METHOD3(OnBufferFilled, 83 MOCK_METHOD3(OnBufferFilled,
85 void(int device_id, int buffer_id, base::Time timestamp)); 84 void(int device_id, int buffer_id, base::Time timestamp));
86 MOCK_METHOD2(OnStateChanged, void(int device_id, VideoCaptureState state)); 85 MOCK_METHOD2(OnStateChanged, void(int device_id, VideoCaptureState state));
87 MOCK_METHOD1(OnDeviceInfo, void(int device_id)); 86 MOCK_METHOD1(OnDeviceInfo, void(int device_id));
88 87
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 IPC_MESSAGE_HANDLER(VideoCaptureMsg_StateChanged, OnStateChangedDispatch) 135 IPC_MESSAGE_HANDLER(VideoCaptureMsg_StateChanged, OnStateChangedDispatch)
137 IPC_MESSAGE_HANDLER(VideoCaptureMsg_DeviceInfo, OnDeviceInfoDispatch) 136 IPC_MESSAGE_HANDLER(VideoCaptureMsg_DeviceInfo, OnDeviceInfoDispatch)
138 IPC_MESSAGE_UNHANDLED(handled = false) 137 IPC_MESSAGE_UNHANDLED(handled = false)
139 IPC_END_MESSAGE_MAP() 138 IPC_END_MESSAGE_MAP()
140 EXPECT_TRUE(handled); 139 EXPECT_TRUE(handled);
141 140
142 delete message; 141 delete message;
143 return true; 142 return true;
144 } 143 }
145 144
146 virtual VideoCaptureManager* GetVideoCaptureManager() OVERRIDE {
147 return manager_->video_capture_manager();
148 }
149
150 // These handler methods do minimal things and delegate to the mock methods. 145 // These handler methods do minimal things and delegate to the mock methods.
151 void OnNewBufferCreatedDispatch(int device_id, 146 void OnNewBufferCreatedDispatch(int device_id,
152 base::SharedMemoryHandle handle, 147 base::SharedMemoryHandle handle,
153 int length, int buffer_id) { 148 int length, int buffer_id) {
154 OnNewBufferCreated(device_id, handle, length, buffer_id); 149 OnNewBufferCreated(device_id, handle, length, buffer_id);
155 base::SharedMemory* dib = new base::SharedMemory(handle, false); 150 base::SharedMemory* dib = new base::SharedMemory(handle, false);
156 dib->Map(length); 151 dib->Map(length);
157 filled_dib_[buffer_id] = dib; 152 filled_dib_[buffer_id] = dib;
158 } 153 }
159 154
(...skipping 20 matching lines...) Expand all
180 if (dump_video_) { 175 if (dump_video_) {
181 dumper_.StartDump(params.width, params.height); 176 dumper_.StartDump(params.width, params.height);
182 } 177 }
183 OnDeviceInfo(device_id); 178 OnDeviceInfo(device_id);
184 } 179 }
185 180
186 std::map<int, base::SharedMemory*> filled_dib_; 181 std::map<int, base::SharedMemory*> filled_dib_;
187 bool return_buffers_; 182 bool return_buffers_;
188 bool dump_video_; 183 bool dump_video_;
189 DumpVideo dumper_; 184 DumpVideo dumper_;
190 MediaStreamManager* manager_;
191 }; 185 };
192 186
193 ACTION_P(ExitMessageLoop, message_loop) { 187 ACTION_P(ExitMessageLoop, message_loop) {
194 message_loop->PostTask(FROM_HERE, base::MessageLoop::QuitClosure()); 188 message_loop->PostTask(FROM_HERE, base::MessageLoop::QuitClosure());
195 } 189 }
196 190
197 class VideoCaptureHostTest : public testing::Test { 191 class VideoCaptureHostTest : public testing::Test {
198 public: 192 public:
199 VideoCaptureHostTest() {} 193 VideoCaptureHostTest() {}
200 194
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
373 #ifdef DUMP_VIDEO 367 #ifdef DUMP_VIDEO
374 TEST_F(VideoCaptureHostTest, CaptureAndDumpVideoVga) { 368 TEST_F(VideoCaptureHostTest, CaptureAndDumpVideoVga) {
375 CaptureAndDumpVideo(640, 480, 30); 369 CaptureAndDumpVideo(640, 480, 30);
376 } 370 }
377 TEST_F(VideoCaptureHostTest, CaptureAndDump720P) { 371 TEST_F(VideoCaptureHostTest, CaptureAndDump720P) {
378 CaptureAndDumpVideo(1280, 720, 30); 372 CaptureAndDumpVideo(1280, 720, 30);
379 } 373 }
380 #endif 374 #endif
381 375
382 } // namespace content 376 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698