Minor cleanup to remove the static thread-safe methods on BrowserMainLoop. Initially I thought this…

content/browser/media_devices_monitor.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/media_devices_monitor.h"
 
 #include "content/browser/browser_main_loop.h"
 #include "content/browser/renderer_host/media/media_stream_manager.h"
 #include "content/public/browser/browser_thread.h"
 
 namespace content {
+namespace {
+void EnsureMonitorCaptureDevicesInternal(
+    MediaStreamManager* media_stream_manager) {
+  // Post a EnumerateDevices() API to MSM to start the monitoring.

[scherkus (not reviewing), 2013/06/21 00:42:43]

comment is incorrect

[jam, 2013/06/21 15:38:58]

that's what it was before?

[scherkus (not reviewing), 2013/06/21 16:18:42]

oh I was referring to the "post to start" -- that bit is now accomplished below
where we call PostTask :)

[jam, 2013/06/21 16:49:19]

what I meant was that that comment was there before in the posted method..
anyways i took out the comment, because it was just documenting the function
call below and so was useless

+  media_stream_manager->EnumerateDevices(
+      NULL, -1, -1, MEDIA_DEVICE_AUDIO_CAPTURE, GURL());
+}
+}
 
 void EnsureMonitorCaptureDevices() {
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
-  // Post a EnumerateDevices() API to MSM to start the monitoring.
-  BrowserMainLoop::GetMediaStreamManager()->EnumerateDevices(
-      NULL, -1, -1, MEDIA_DEVICE_AUDIO_CAPTURE, GURL());
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+
+  BrowserThread::PostTask(
+        BrowserThread::IO, FROM_HERE,
+        base::Bind(&EnsureMonitorCaptureDevicesInternal,

[scherkus (not reviewing), 2013/06/21 00:42:43]

I guess we could replace EnsureMonitorCaptureDevicesInternal() by beefing up the
base::Bind()

base::Bind(&MediaStreamManager::EnumerateDevices,
BrowserMainLoop::GetInstance()->media_stream_manager(), NULL, -1, -1,
MEDIA_DEVICE_AUDIO_CAPTURE, GURL())

[jam, 2013/06/21 15:38:58]

Done. it ended up looking not so pretty though because of bind quirks (i.e.
needed a MediaStreamRequester pointer instead of NULL because it couldn't deduce
its type, ignoreresult, unretained), let me know if you want to change it back.

+                   BrowserMainLoop::GetInstance()->media_stream_manager()));
 }
 
 }  // namespace content