DevTools: migrate protocol values from RefPtr to OwnPtr.

DevTools: migrate protocol values from RefPtr to OwnPtr.

BUG=580337
Committed: https://crrev.com/e8903f001fe670d33ee3b34cc43fc8a5cb778509
Cr-Commit-Position: refs/heads/master@{#378575}

[pfeldman, 2016-03-01 00:20:24]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-03-01 01:45:06]

lgtm

https://codereview.chromium.org/1745423002/diff/1/third_party/WebKit/Source/p...
File
third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template
(right):

https://codereview.chromium.org/1745423002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template:214:
ASSERT(parsedMessage);
Unrelated, but asserting protocol input is a brave move.

https://codereview.chromium.org/1745423002/diff/1/third_party/WebKit/Source/p...
File
third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template
(right):

https://codereview.chromium.org/1745423002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template:72:
return adoptPtr(new
Object(adoptPtr(static_cast<DictionaryValue*>(object->clone().leakPtr()))));
5 closing ) in a row. Wow.

https://codereview.chromium.org/1745423002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template:95:
PassOwnPtr<protocol::Value> toValue(const OwnPtr<Value>& param) { return
param->clone(); }
Who needs this? Should we just call .get() on callsites?

https://codereview.chromium.org/1745423002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/inspector_protocol/Values.cpp (right):

https://codereview.chromium.org/1745423002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/inspector_protocol/Values.cpp:289:
ASSERT_WITH_SECURITY_IMPLICATION(it != m_data.end());
Security implication? Why not just assert?

https://codereview.chromium.org/1745423002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp (right):

https://codereview.chromium.org/1745423002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:467: void
InjectedScript::makeCall(V8FunctionCall& function, OwnPtr<protocol::Value>*
result)
Returning PassOwnPtr<protocol::Value> would be more conventional.

[pfeldman, 2016-03-01 02:41:51]

All done.

https://codereview.chromium.org/1745423002/diff/1/third_party/WebKit/Source/p...
File
third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template
(right):

https://codereview.chromium.org/1745423002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template:214:
ASSERT(parsedMessage);
On 2016/03/01 01:45:05, dgozman wrote:
> Unrelated, but asserting protocol input is a brave move.

I think that content won't let malformed message in.

[pfeldman, 2016-03-01 02:42:01]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-03-01 02:42:02]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1745423002/#ps40001
(title: "review comments addressed.")

[commit-bot: I haz the power, 2016-03-01 02:42:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1745423002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1745423002/40001

[commit-bot: I haz the power, 2016-03-01 02:57:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 02:57:28]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[pfeldman, 2016-03-01 04:12:03]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-03-01 04:12:04]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1745423002/#ps60001
(title: "compile fix")

[commit-bot: I haz the power, 2016-03-01 04:12:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1745423002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1745423002/60001

[commit-bot: I haz the power, 2016-03-01 05:28:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 05:29:00]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[pfeldman, 2016-03-01 17:04:50]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-03-01 17:04:51]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1745423002/#ps80001
(title: "attempt to fix win")

[commit-bot: I haz the power, 2016-03-01 17:05:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1745423002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1745423002/80001

[commit-bot: I haz the power, 2016-03-01 17:17:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 17:18:00]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[pfeldman, 2016-03-01 18:23:50]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-03-01 18:23:51]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1745423002/#ps100001
(title: "assert")

[commit-bot: I haz the power, 2016-03-01 18:24:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1745423002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1745423002/100001

[commit-bot: I haz the power, 2016-03-01 19:36:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 19:36:13]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[pfeldman, 2016-03-01 20:18:41]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-03-01 20:18:42]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1745423002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2016-03-01 20:19:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1745423002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1745423002/140001

[commit-bot: I haz the power, 2016-03-01 22:15:14]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-03-01 22:16:48]

Description was changed from

==========
DevTools: migrate protocol values from RefPtr to OwnPtr.

BUG=580337
==========

to

==========
DevTools: migrate protocol values from RefPtr to OwnPtr.

BUG=580337

Committed: https://crrev.com/e8903f001fe670d33ee3b34cc43fc8a5cb778509
Cr-Commit-Position: refs/heads/master@{#378575}
==========

[commit-bot: I haz the power, 2016-03-01 22:16:50]

Patchset 8 (id:??) landed as
https://crrev.com/e8903f001fe670d33ee3b34cc43fc8a5cb778509
Cr-Commit-Position: refs/heads/master@{#378575}