third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h - Issue 1745423002: DevTools: migrate protocol values from RefPtr to OwnPtr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

Issue 1745423002: DevTools: migrate protocol values from RefPtr to OwnPtr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h ('k') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

index 9075d8433456a2d013f1eb0f4b99c2a837dd5e5f..41fc727bee3346c26e07f67553606d2e80e441aa 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

@@ -56,7 +56,7 @@ public:

~V8RuntimeAgentImpl() override;

// State management methods.

- void setInspectorState(PassRefPtr<protocol::DictionaryValue>) override;

+ void setInspectorState(protocol::DictionaryValue*) override;

void setFrontend(protocol::Frontend::Runtime*) override;

void clearFrontend() override;

void restore() override;

@@ -131,7 +131,7 @@ private:

void reportExecutionContextDestroyed(v8::Local<v8::Context>) override;

PassOwnPtr<protocol::Runtime::ExceptionDetails> createExceptionDetails(v8::Isolate*, v8::Local<v8::Message>);

- RefPtr<protocol::DictionaryValue> m_state;

+ protocol::DictionaryValue* m_state;

protocol::Frontend::Runtime* m_frontend;

OwnPtr<InjectedScriptManager> m_injectedScriptManager;

V8DebuggerImpl* m_debugger;