Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

Issue 1745423002: DevTools: migrate protocol values from RefPtr to OwnPtr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 49
50 using protocol::Maybe; 50 using protocol::Maybe;
51 51
52 class V8RuntimeAgentImpl : public V8RuntimeAgent { 52 class V8RuntimeAgentImpl : public V8RuntimeAgent {
53 WTF_MAKE_NONCOPYABLE(V8RuntimeAgentImpl); 53 WTF_MAKE_NONCOPYABLE(V8RuntimeAgentImpl);
54 public: 54 public:
55 V8RuntimeAgentImpl(V8DebuggerImpl*); 55 V8RuntimeAgentImpl(V8DebuggerImpl*);
56 ~V8RuntimeAgentImpl() override; 56 ~V8RuntimeAgentImpl() override;
57 57
58 // State management methods. 58 // State management methods.
59 void setInspectorState(PassRefPtr<protocol::DictionaryValue>) override; 59 void setInspectorState(protocol::DictionaryValue*) override;
60 void setFrontend(protocol::Frontend::Runtime*) override; 60 void setFrontend(protocol::Frontend::Runtime*) override;
61 void clearFrontend() override; 61 void clearFrontend() override;
62 void restore() override; 62 void restore() override;
63 63
64 // Part of the protocol. 64 // Part of the protocol.
65 void enable(ErrorString*) override; 65 void enable(ErrorString*) override;
66 void disable(ErrorString*) override; 66 void disable(ErrorString*) override;
67 void evaluate(ErrorString*, 67 void evaluate(ErrorString*,
68 const String& expression, 68 const String& expression,
69 const Maybe<String>& objectGroup, 69 const Maybe<String>& objectGroup,
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 PassOwnPtr<protocol::Runtime::RemoteObject> wrapTable(v8::Local<v8::Context> , v8::Local<v8::Value> table, v8::Local<v8::Value> columns) override; 124 PassOwnPtr<protocol::Runtime::RemoteObject> wrapTable(v8::Local<v8::Context> , v8::Local<v8::Value> table, v8::Local<v8::Value> columns) override;
125 void disposeObjectGroup(const String&) override; 125 void disposeObjectGroup(const String&) override;
126 v8::Local<v8::Value> findObject(const String& objectId, v8::Local<v8::Contex t>* = nullptr, String* groupName = nullptr) override; 126 v8::Local<v8::Value> findObject(const String& objectId, v8::Local<v8::Contex t>* = nullptr, String* groupName = nullptr) override;
127 void addInspectedObject(PassOwnPtr<Inspectable>) override; 127 void addInspectedObject(PassOwnPtr<Inspectable>) override;
128 void clearInspectedObjects() override; 128 void clearInspectedObjects() override;
129 129
130 void reportExecutionContextCreated(v8::Local<v8::Context>, const String& typ e, const String& origin, const String& humanReadableName, const String& frameId) override; 130 void reportExecutionContextCreated(v8::Local<v8::Context>, const String& typ e, const String& origin, const String& humanReadableName, const String& frameId) override;
131 void reportExecutionContextDestroyed(v8::Local<v8::Context>) override; 131 void reportExecutionContextDestroyed(v8::Local<v8::Context>) override;
132 PassOwnPtr<protocol::Runtime::ExceptionDetails> createExceptionDetails(v8::I solate*, v8::Local<v8::Message>); 132 PassOwnPtr<protocol::Runtime::ExceptionDetails> createExceptionDetails(v8::I solate*, v8::Local<v8::Message>);
133 133
134 RefPtr<protocol::DictionaryValue> m_state; 134 protocol::DictionaryValue* m_state;
135 protocol::Frontend::Runtime* m_frontend; 135 protocol::Frontend::Runtime* m_frontend;
136 OwnPtr<InjectedScriptManager> m_injectedScriptManager; 136 OwnPtr<InjectedScriptManager> m_injectedScriptManager;
137 V8DebuggerImpl* m_debugger; 137 V8DebuggerImpl* m_debugger;
138 bool m_enabled; 138 bool m_enabled;
139 HashMap<String, OwnPtr<v8::Global<v8::Script>>> m_compiledScripts; 139 HashMap<String, OwnPtr<v8::Global<v8::Script>>> m_compiledScripts;
140 }; 140 };
141 141
142 } // namespace blink 142 } // namespace blink
143 143
144 #endif // V8RuntimeAgentImpl_h 144 #endif // V8RuntimeAgentImpl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698