Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

Issue 1745423002: DevTools: migrate protocol values from RefPtr to OwnPtr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 } 294 }
295 295
296 if (value.IsEmpty()) { 296 if (value.IsEmpty()) {
297 *errorString = "Script execution failed"; 297 *errorString = "Script execution failed";
298 return; 298 return;
299 } 299 }
300 300
301 *result = injectedScript->wrapObject(value, objectGroup.fromMaybe("")); 301 *result = injectedScript->wrapObject(value, objectGroup.fromMaybe(""));
302 } 302 }
303 303
304 void V8RuntimeAgentImpl::setInspectorState(PassRefPtr<protocol::DictionaryValue> state) 304 void V8RuntimeAgentImpl::setInspectorState(protocol::DictionaryValue* state)
305 { 305 {
306 m_state = state; 306 m_state = state;
307 } 307 }
308 308
309 void V8RuntimeAgentImpl::setFrontend(protocol::Frontend::Runtime* frontend) 309 void V8RuntimeAgentImpl::setFrontend(protocol::Frontend::Runtime* frontend)
310 { 310 {
311 m_frontend = frontend; 311 m_frontend = frontend;
312 } 312 }
313 313
314 void V8RuntimeAgentImpl::clearFrontend() 314 void V8RuntimeAgentImpl::clearFrontend()
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
435 OwnPtr<ExceptionDetails> exceptionDetails = ExceptionDetails::create().setTe xt(toWTFStringWithTypeCheck(message->Get())).build(); 435 OwnPtr<ExceptionDetails> exceptionDetails = ExceptionDetails::create().setTe xt(toWTFStringWithTypeCheck(message->Get())).build();
436 exceptionDetails->setLine(message->GetLineNumber()); 436 exceptionDetails->setLine(message->GetLineNumber());
437 exceptionDetails->setColumn(message->GetStartColumn()); 437 exceptionDetails->setColumn(message->GetStartColumn());
438 v8::Local<v8::StackTrace> messageStackTrace = message->GetStackTrace(); 438 v8::Local<v8::StackTrace> messageStackTrace = message->GetStackTrace();
439 if (!messageStackTrace.IsEmpty() && messageStackTrace->GetFrameCount() > 0) 439 if (!messageStackTrace.IsEmpty() && messageStackTrace->GetFrameCount() > 0)
440 exceptionDetails->setStack(m_debugger->createStackTrace(messageStackTrac e, messageStackTrace->GetFrameCount())->buildInspectorObject()); 440 exceptionDetails->setStack(m_debugger->createStackTrace(messageStackTrac e, messageStackTrace->GetFrameCount())->buildInspectorObject());
441 return exceptionDetails.release(); 441 return exceptionDetails.release();
442 } 442 }
443 443
444 } // namespace blink 444 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698