third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp - Issue 1745423002: DevTools: migrate protocol values from RefPtr to OwnPtr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp

Issue 1745423002: DevTools: migrate protocol values from RefPtr to OwnPtr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp ('k') | third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp

diff --git a/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp b/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp

index 8c86ed6aa4ab287b1077dee3e77c5af2833128d0..be950bd49c8708fef51ca9e71c8689ed2b21572e 100644

--- a/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp

+++ b/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp

@@ -63,7 +63,7 @@ void reportTransactionFailed(ExecuteSQLCallback* requestCallback, SQLError* erro

OwnPtr<protocol::Database::Error> errorObject = protocol::Database::Error::create()

.setMessage(error->message())

.setCode(error->code()).build();

- requestCallback->sendSuccess(Maybe<protocol::Array<String>>(), Maybe<protocol::Array<RefPtr<protocol::Value>>>(), errorObject.release());

+ requestCallback->sendSuccess(Maybe<protocol::Array<String>>(), Maybe<protocol::Array<protocol::Value>>(), errorObject.release());

}

class StatementCallback final : public SQLStatementCallback {

@@ -89,7 +89,7 @@ public:

for (size_t i = 0; i < columns.size(); ++i)

columnNames->addItem(columns[i]);

- OwnPtr<protocol::Array<RefPtr<protocol::Value>>> values = protocol::Array<RefPtr<protocol::Value>>::create();

+ OwnPtr<protocol::Array<protocol::Value>> values = protocol::Array<protocol::Value>::create();

const Vector<SQLValue>& data = rowList->values();

for (size_t i = 0; i < data.size(); ++i) {

const SQLValue& value = rowList->values()[i];