Reduce ActiveDOMObjects from modules/mediastream/

Reduce ActiveDOMObjects from modules/mediastream/

Per the plan described in https://groups.google.com/a/chromium.org/d/topic/blink-dev/UwRGJgLBElo/discussion,
this CL replaces ActiveDOMObjects in modules/mediastream/ with ContextLifecycleObservers.

BUG=589507
Committed: https://crrev.com/bd162ec5dcf4377d94bc08b871a64945a2793612
Cr-Commit-Position: refs/heads/master@{#378336}

[haraken, 2016-02-29 07:56:50]

haraken@chromium.org changed reviewers:
+ tommi@chromium.org

[haraken, 2016-02-29 07:56:51]

PTAL

[haraken, 2016-02-29 11:20:35]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2016-02-29 11:20:35]

(cc Sigbjorn for sanity checking)

[haraken, 2016-02-29 11:20:50]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-29 11:21:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1744133002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1744133002/20001

[tommi (sloooow) - chröme, 2016-02-29 13:13:26]

tommi@chromium.org changed reviewers:
+ guidou@chromium.org

[tommi (sloooow) - chröme, 2016-02-29 13:13:27]

Guido - can you take a look?

[Guido Urdaneta, 2016-02-29 13:16:39]

lgtm

[tommi (sloooow) - chröme, 2016-02-29 13:19:52]

Thanks Guido - rs lgtm.

[commit-bot: I haz the power, 2016-02-29 14:20:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 14:20:29]

Dry run: This issue passed the CQ dry run.

[sof, 2016-02-29 19:06:38]

looks good.

The contextDestroyed() overrides calling clear() -- an alternative would be not
to define those and test !executionContext() in the various callbacks instead.

[haraken, 2016-03-01 00:00:00]

On 2016/02/29 19:06:38, sof wrote:
> looks good.
> 
> The contextDestroyed() overrides calling clear() -- an alternative would be
not
> to define those and test !executionContext() in the various callbacks instead.

In that case, we'll need to call contextDestroyed() when finishing
requestSucceeded/requestFailed etc. I personally want to avoid calling
contextDestroyed manually and keep the model that only the LifecycleNotifier has
a privilege to call contextDestroyed.

[haraken, 2016-03-01 00:00:08]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-03-01 00:00:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1744133002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1744133002/20001

[commit-bot: I haz the power, 2016-03-01 00:12:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-01 00:14:07]

Description was changed from

==========
Reduce ActiveDOMObjects from modules/mediastream/

Per the plan described in
https://groups.google.com/a/chromium.org/d/topic/blink-dev/UwRGJgLBElo/discus...,
this CL replaces ActiveDOMObjects in modules/mediastream/ with
ContextLifecycleObservers.

BUG=589507
==========

to

==========
Reduce ActiveDOMObjects from modules/mediastream/

Per the plan described in
https://groups.google.com/a/chromium.org/d/topic/blink-dev/UwRGJgLBElo/discus...,
this CL replaces ActiveDOMObjects in modules/mediastream/ with
ContextLifecycleObservers.

BUG=589507

Committed: https://crrev.com/bd162ec5dcf4377d94bc08b871a64945a2793612
Cr-Commit-Position: refs/heads/master@{#378336}
==========

[commit-bot: I haz the power, 2016-03-01 00:14:08]

Patchset 2 (id:??) landed as
https://crrev.com/bd162ec5dcf4377d94bc08b871a64945a2793612
Cr-Commit-Position: refs/heads/master@{#378336}

[sof, 2016-03-01 06:18:46]

On 2016/03/01 00:00:00, haraken wrote:
> On 2016/02/29 19:06:38, sof wrote:
> > looks good.
> > 
> > The contextDestroyed() overrides calling clear() -- an alternative would be
> not
> > to define those and test !executionContext() in the various callbacks
instead.
> 
> In that case, we'll need to call contextDestroyed() when finishing
> requestSucceeded/requestFailed etc. I personally want to avoid calling
> contextDestroyed manually and keep the model that only the LifecycleNotifier
has
> a privilege to call contextDestroyed.

There would be nothing stopping those from still using clear() to transition the
object to a detached state.

But other than reducing contextDestroyed() special handling, this doesn't
represent a clear improvement. But worth bringing up.

[haraken, 2016-03-02 16:03:14]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1758783002/ by haraken@chromium.org.

The reason for reverting is: I noticed that we're not ready to remove the
m_stopped variable (because LifecycleObserver does not yet have an ability to
clear LifecycleObserver::m_context when the context is destroyed). We need to
fix the LifecycleObserver before landing this fix.
.