Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.h

Issue 1744133002: Reduce ActiveDOMObjects from modules/mediastream/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY GOOGLE INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY GOOGLE INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL GOOGLE INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL GOOGLE INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef MediaDevicesRequest_h 26 #ifndef MediaDevicesRequest_h
27 #define MediaDevicesRequest_h 27 #define MediaDevicesRequest_h
28 28
29 #include "bindings/core/v8/ScriptPromise.h" 29 #include "bindings/core/v8/ScriptPromise.h"
30 #include "core/dom/ActiveDOMObject.h" 30 #include "core/dom/ContextLifecycleObserver.h"
31 #include "modules/ModulesExport.h" 31 #include "modules/ModulesExport.h"
32 #include "modules/mediastream/MediaDeviceInfo.h" 32 #include "modules/mediastream/MediaDeviceInfo.h"
33 #include "platform/heap/Handle.h" 33 #include "platform/heap/Handle.h"
34 #include "wtf/PassOwnPtr.h" 34 #include "wtf/PassOwnPtr.h"
35 35
36 namespace blink { 36 namespace blink {
37 37
38 class Document; 38 class Document;
39 class ExceptionState; 39 class ExceptionState;
40 class UserMediaController; 40 class UserMediaController;
41 class ScriptState; 41 class ScriptState;
42 class ScriptPromiseResolver; 42 class ScriptPromiseResolver;
43 43
44 class MODULES_EXPORT MediaDevicesRequest final : public GarbageCollectedFinalize d<MediaDevicesRequest>, public ActiveDOMObject { 44 // TODO(haraken): Make this GarbageCollected once the WillBe type is removed.
45 class MODULES_EXPORT MediaDevicesRequest final : public GarbageCollectedFinalize d<MediaDevicesRequest>, public ContextLifecycleObserver {
45 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MediaDevicesRequest); 46 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MediaDevicesRequest);
46 public: 47 public:
47 static MediaDevicesRequest* create(ScriptState*, UserMediaController*); 48 static MediaDevicesRequest* create(ScriptState*, UserMediaController*);
48 ~MediaDevicesRequest() override;
49 49
50 Document* ownerDocument(); 50 Document* ownerDocument();
51 51
52 ScriptPromise start(); 52 ScriptPromise start();
53 53
54 void succeed(const MediaDeviceInfoVector&); 54 void succeed(const MediaDeviceInfoVector&);
55 55
56 // ActiveDOMObject 56 void contextDestroyed() override;
57 void stop() override;
58 57
59 DECLARE_VIRTUAL_TRACE(); 58 DECLARE_VIRTUAL_TRACE();
60 59
61 private: 60 private:
62 MediaDevicesRequest(ScriptState*, UserMediaController*); 61 MediaDevicesRequest(ScriptState*, UserMediaController*);
63 62
64 RawPtrWillBeMember<UserMediaController> m_controller; 63 RawPtrWillBeMember<UserMediaController> m_controller;
65 Member<ScriptPromiseResolver> m_resolver; 64 Member<ScriptPromiseResolver> m_resolver;
66 }; 65 };
67 66
68 } // namespace blink 67 } // namespace blink
69 68
70 #endif // MediaDevicesRequest_h 69 #endif // MediaDevicesRequest_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698