Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp

Issue 1744133002: Reduce ActiveDOMObjects from modules/mediastream/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 25 matching lines...) Expand all
36 #include "modules/mediastream/RTCPeerConnectionErrorCallback.h" 36 #include "modules/mediastream/RTCPeerConnectionErrorCallback.h"
37 #include "modules/mediastream/RTCSessionDescription.h" 37 #include "modules/mediastream/RTCSessionDescription.h"
38 #include "modules/mediastream/RTCSessionDescriptionCallback.h" 38 #include "modules/mediastream/RTCSessionDescriptionCallback.h"
39 #include "public/platform/WebRTCSessionDescription.h" 39 #include "public/platform/WebRTCSessionDescription.h"
40 #include "wtf/RefPtr.h" 40 #include "wtf/RefPtr.h"
41 41
42 namespace blink { 42 namespace blink {
43 43
44 RTCSessionDescriptionRequestImpl* RTCSessionDescriptionRequestImpl::create(Execu tionContext* context, RTCPeerConnection* requester, RTCSessionDescriptionCallbac k* successCallback, RTCPeerConnectionErrorCallback* errorCallback) 44 RTCSessionDescriptionRequestImpl* RTCSessionDescriptionRequestImpl::create(Execu tionContext* context, RTCPeerConnection* requester, RTCSessionDescriptionCallbac k* successCallback, RTCPeerConnectionErrorCallback* errorCallback)
45 { 45 {
46 RTCSessionDescriptionRequestImpl* request = new RTCSessionDescriptionRequest Impl(context, requester, successCallback, errorCallback); 46 return new RTCSessionDescriptionRequestImpl(context, requester, successCallb ack, errorCallback);
47 request->suspendIfNeeded();
48 return request;
49 } 47 }
50 48
51 RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl(ExecutionCont ext* context, RTCPeerConnection* requester, RTCSessionDescriptionCallback* succe ssCallback, RTCPeerConnectionErrorCallback* errorCallback) 49 RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl(ExecutionCont ext* context, RTCPeerConnection* requester, RTCSessionDescriptionCallback* succe ssCallback, RTCPeerConnectionErrorCallback* errorCallback)
52 : ActiveDOMObject(context) 50 : ContextLifecycleObserver(context)
53 , m_successCallback(successCallback) 51 , m_successCallback(successCallback)
54 , m_errorCallback(errorCallback) 52 , m_errorCallback(errorCallback)
55 , m_requester(requester) 53 , m_requester(requester)
56 { 54 {
57 ASSERT(m_requester); 55 ASSERT(m_requester);
58 } 56 }
59 57
60 RTCSessionDescriptionRequestImpl::~RTCSessionDescriptionRequestImpl() 58 RTCSessionDescriptionRequestImpl::~RTCSessionDescriptionRequestImpl()
61 { 59 {
62 } 60 }
63 61
64 void RTCSessionDescriptionRequestImpl::requestSucceeded(const WebRTCSessionDescr iption& webSessionDescription) 62 void RTCSessionDescriptionRequestImpl::requestSucceeded(const WebRTCSessionDescr iption& webSessionDescription)
65 { 63 {
66 bool shouldFireCallback = m_requester ? m_requester->shouldFireDefaultCallba cks() : false; 64 bool shouldFireCallback = m_requester ? m_requester->shouldFireDefaultCallba cks() : false;
67 if (shouldFireCallback && m_successCallback) 65 if (shouldFireCallback && m_successCallback)
68 m_successCallback->handleEvent(RTCSessionDescription::create(webSessionD escription)); 66 m_successCallback->handleEvent(RTCSessionDescription::create(webSessionD escription));
69 clear(); 67 clear();
70 } 68 }
71 69
72 void RTCSessionDescriptionRequestImpl::requestFailed(const String& error) 70 void RTCSessionDescriptionRequestImpl::requestFailed(const String& error)
73 { 71 {
74 bool shouldFireCallback = m_requester ? m_requester->shouldFireDefaultCallba cks() : false; 72 bool shouldFireCallback = m_requester ? m_requester->shouldFireDefaultCallba cks() : false;
75 if (shouldFireCallback && m_errorCallback) 73 if (shouldFireCallback && m_errorCallback)
76 m_errorCallback->handleEvent(DOMException::create(OperationError, error) ); 74 m_errorCallback->handleEvent(DOMException::create(OperationError, error) );
77 75
78 clear(); 76 clear();
79 } 77 }
80 78
81 void RTCSessionDescriptionRequestImpl::stop() 79 void RTCSessionDescriptionRequestImpl::contextDestroyed()
82 { 80 {
83 clear(); 81 clear();
84 } 82 }
85 83
86 void RTCSessionDescriptionRequestImpl::clear() 84 void RTCSessionDescriptionRequestImpl::clear()
87 { 85 {
88 m_successCallback.clear(); 86 m_successCallback.clear();
89 m_errorCallback.clear(); 87 m_errorCallback.clear();
90 m_requester.clear(); 88 m_requester.clear();
91 } 89 }
92 90
93 DEFINE_TRACE(RTCSessionDescriptionRequestImpl) 91 DEFINE_TRACE(RTCSessionDescriptionRequestImpl)
94 { 92 {
95 visitor->trace(m_successCallback); 93 visitor->trace(m_successCallback);
96 visitor->trace(m_errorCallback); 94 visitor->trace(m_errorCallback);
97 visitor->trace(m_requester); 95 visitor->trace(m_requester);
98 RTCSessionDescriptionRequest::trace(visitor); 96 RTCSessionDescriptionRequest::trace(visitor);
99 ActiveDOMObject::trace(visitor); 97 ContextLifecycleObserver::trace(visitor);
100 } 98 }
101 99
102 } // namespace blink 100 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698