third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h - Issue 1744133002: Reduce ActiveDOMObjects from modules/mediastream/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

Issue 1744133002: Reduce ActiveDOMObjects from modules/mediastream/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/RTCDTMFSender.cpp ('k') | third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

diff --git a/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h b/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

index 86d534e2527d93a4dab0e195016a83ef31106e1a..125c4b8d1b9a0c13d037b749c8d12998879f9345 100644

--- a/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

+++ b/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

@@ -31,7 +31,7 @@

#ifndef RTCSessionDescriptionRequestImpl_h

#define RTCSessionDescriptionRequestImpl_h

-#include "core/dom/ActiveDOMObject.h"

+#include "core/dom/ContextLifecycleObserver.h"

#include "platform/heap/Handle.h"

#include "platform/mediastream/RTCSessionDescriptionRequest.h"

#include "wtf/PassOwnPtr.h"

@@ -44,7 +44,7 @@ class RTCPeerConnectionErrorCallback;

class RTCSessionDescriptionCallback;

class WebRTCSessionDescription;

-class RTCSessionDescriptionRequestImpl final : public RTCSessionDescriptionRequest, public ActiveDOMObject {

+class RTCSessionDescriptionRequestImpl final : public RTCSessionDescriptionRequest, public ContextLifecycleObserver {

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(RTCSessionDescriptionRequestImpl);

public:

static RTCSessionDescriptionRequestImpl* create(ExecutionContext*, RTCPeerConnection*, RTCSessionDescriptionCallback*, RTCPeerConnectionErrorCallback*);

@@ -53,8 +53,7 @@ public:

void requestSucceeded(const WebRTCSessionDescription&) override;

void requestFailed(const String& error) override;

- // ActiveDOMObject

- void stop() override;

+ void contextDestroyed() override;

DECLARE_VIRTUAL_TRACE();