Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/RTCDTMFSender.cpp

Issue 1744133002: Reduce ActiveDOMObjects from modules/mediastream/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 static const int defaultInterToneGapMs = 50; 44 static const int defaultInterToneGapMs = 50;
45 45
46 RTCDTMFSender* RTCDTMFSender::create(ExecutionContext* context, WebRTCPeerConnec tionHandler* peerConnectionHandler, MediaStreamTrack* track, ExceptionState& exc eptionState) 46 RTCDTMFSender* RTCDTMFSender::create(ExecutionContext* context, WebRTCPeerConnec tionHandler* peerConnectionHandler, MediaStreamTrack* track, ExceptionState& exc eptionState)
47 { 47 {
48 OwnPtr<WebRTCDTMFSenderHandler> handler = adoptPtr(peerConnectionHandler->cr eateDTMFSender(track->component())); 48 OwnPtr<WebRTCDTMFSenderHandler> handler = adoptPtr(peerConnectionHandler->cr eateDTMFSender(track->component()));
49 if (!handler) { 49 if (!handler) {
50 exceptionState.throwDOMException(NotSupportedError, "The MediaStreamTrac k provided is not an element of a MediaStream that's currently in the local stre ams set."); 50 exceptionState.throwDOMException(NotSupportedError, "The MediaStreamTrac k provided is not an element of a MediaStream that's currently in the local stre ams set.");
51 return nullptr; 51 return nullptr;
52 } 52 }
53 53
54 RTCDTMFSender* dtmfSender = new RTCDTMFSender(context, track, handler.releas e()); 54 return new RTCDTMFSender(context, track, handler.release());
55 dtmfSender->suspendIfNeeded();
56 return dtmfSender;
57 } 55 }
58 56
59 RTCDTMFSender::RTCDTMFSender(ExecutionContext* context, MediaStreamTrack* track, PassOwnPtr<WebRTCDTMFSenderHandler> handler) 57 RTCDTMFSender::RTCDTMFSender(ExecutionContext* context, MediaStreamTrack* track, PassOwnPtr<WebRTCDTMFSenderHandler> handler)
60 : ActiveDOMObject(context) 58 : ContextLifecycleObserver(context)
61 , m_track(track) 59 , m_track(track)
62 , m_duration(defaultToneDurationMs) 60 , m_duration(defaultToneDurationMs)
63 , m_interToneGap(defaultInterToneGapMs) 61 , m_interToneGap(defaultInterToneGapMs)
64 , m_handler(handler) 62 , m_handler(handler)
65 , m_stopped(false)
66 , m_scheduledEventTimer(this, &RTCDTMFSender::scheduledEventTimerFired) 63 , m_scheduledEventTimer(this, &RTCDTMFSender::scheduledEventTimerFired)
67 { 64 {
68 m_handler->setClient(this); 65 m_handler->setClient(this);
69 } 66 }
70 67
71 RTCDTMFSender::~RTCDTMFSender() 68 RTCDTMFSender::~RTCDTMFSender()
72 { 69 {
73 } 70 }
74 71
75 bool RTCDTMFSender::canInsertDTMF() const 72 bool RTCDTMFSender::canInsertDTMF() const
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 scheduleDispatchEvent(RTCDTMFToneChangeEvent::create(tone)); 123 scheduleDispatchEvent(RTCDTMFToneChangeEvent::create(tone));
127 } 124 }
128 125
129 const AtomicString& RTCDTMFSender::interfaceName() const 126 const AtomicString& RTCDTMFSender::interfaceName() const
130 { 127 {
131 return EventTargetNames::RTCDTMFSender; 128 return EventTargetNames::RTCDTMFSender;
132 } 129 }
133 130
134 ExecutionContext* RTCDTMFSender::executionContext() const 131 ExecutionContext* RTCDTMFSender::executionContext() const
135 { 132 {
136 return ActiveDOMObject::executionContext(); 133 return ContextLifecycleObserver::executionContext();
137 } 134 }
138 135
139 void RTCDTMFSender::stop() 136 void RTCDTMFSender::contextDestroyed()
140 { 137 {
141 m_stopped = true;
142 m_handler->setClient(0); 138 m_handler->setClient(0);
143 } 139 }
144 140
145 void RTCDTMFSender::scheduleDispatchEvent(PassRefPtrWillBeRawPtr<Event> event) 141 void RTCDTMFSender::scheduleDispatchEvent(PassRefPtrWillBeRawPtr<Event> event)
146 { 142 {
147 m_scheduledEvents.append(event); 143 m_scheduledEvents.append(event);
148 144
149 if (!m_scheduledEventTimer.isActive()) 145 if (!m_scheduledEventTimer.isActive())
150 m_scheduledEventTimer.startOneShot(0, BLINK_FROM_HERE); 146 m_scheduledEventTimer.startOneShot(0, BLINK_FROM_HERE);
151 } 147 }
152 148
153 void RTCDTMFSender::scheduledEventTimerFired(Timer<RTCDTMFSender>*) 149 void RTCDTMFSender::scheduledEventTimerFired(Timer<RTCDTMFSender>*)
154 { 150 {
155 if (m_stopped) 151 if (!executionContext())
156 return; 152 return;
157 153
158 WillBeHeapVector<RefPtrWillBeMember<Event>> events; 154 WillBeHeapVector<RefPtrWillBeMember<Event>> events;
159 events.swap(m_scheduledEvents); 155 events.swap(m_scheduledEvents);
160 156
161 WillBeHeapVector<RefPtrWillBeMember<Event>>::iterator it = events.begin(); 157 WillBeHeapVector<RefPtrWillBeMember<Event>>::iterator it = events.begin();
162 for (; it != events.end(); ++it) 158 for (; it != events.end(); ++it)
163 dispatchEvent((*it).release()); 159 dispatchEvent((*it).release());
164 } 160 }
165 161
166 DEFINE_TRACE(RTCDTMFSender) 162 DEFINE_TRACE(RTCDTMFSender)
167 { 163 {
168 visitor->trace(m_track); 164 visitor->trace(m_track);
169 visitor->trace(m_scheduledEvents); 165 visitor->trace(m_scheduledEvents);
170 RefCountedGarbageCollectedEventTargetWithInlineData<RTCDTMFSender>::trace(vi sitor); 166 RefCountedGarbageCollectedEventTargetWithInlineData<RTCDTMFSender>::trace(vi sitor);
171 ActiveDOMObject::trace(visitor); 167 ContextLifecycleObserver::trace(visitor);
172 } 168 }
173 169
174 } // namespace blink 170 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698