Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1741733003: Fix clang warning "has virtual functions but non-virtual destructor". (Closed)

Created:
4 years, 10 months ago by Sean Klein
Modified:
4 years, 9 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/IceAssembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceFixups.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceInst.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceOperand.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Sean Klein
4 years, 10 months ago (2016-02-27 00:16:37 UTC) #3
Jim Stichnoth
lgtm
4 years, 9 months ago (2016-02-27 17:42:32 UTC) #4
Sean Klein
4 years, 9 months ago (2016-03-01 00:44:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fc707ffe812339bddf4ca28fbe8c01045e2b42d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698