src/IceOperand.h - Issue 1741733003: Fix clang warning "has virtual functions but non-virtual destructor".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceOperand.h

Issue 1741733003: Fix clang warning "has virtual functions but non-virtual destructor". (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceOperand.h

diff --git a/src/IceOperand.h b/src/IceOperand.h

index 443e2d01ddefc98b642c3de936671cd878e1098f..f3a66fcba0c0ee488a802c6cb4258a97a7ef800d 100644

--- a/src/IceOperand.h

+++ b/src/IceOperand.h

@@ -91,7 +91,7 @@ public:

}

/// @}

- ~Operand() = default;

+ virtual ~Operand() = default;

protected:

Operand(OperandKind Kind, Type Ty) : Ty(Ty), Kind(Kind) {

« no previous file with comments | « src/IceInst.h ('k') | no next file » | no next file with comments »