Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: src/IceFixups.h

Issue 1741733003: Fix clang warning "has virtual functions but non-virtual destructor". (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceAssembler.h ('k') | src/IceInst.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceFixups.h
diff --git a/src/IceFixups.h b/src/IceFixups.h
index fb8a164eadc70306e32e27b317a21f99c9a34f11..1a29a18650ef67c600f6eace1cd07b5166b5de54 100644
--- a/src/IceFixups.h
+++ b/src/IceFixups.h
@@ -31,6 +31,7 @@ class AssemblerFixup {
public:
AssemblerFixup() = default;
AssemblerFixup(const AssemblerFixup &) = default;
+ virtual ~AssemblerFixup() = default;
intptr_t position() const {
assert(position_was_set_);
return position_;
« no previous file with comments | « src/IceAssembler.h ('k') | src/IceInst.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698