Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: src/IceInst.h

Issue 1741733003: Fix clang warning "has virtual functions but non-virtual destructor". (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/IceFixups.h ('k') | src/IceOperand.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 //===- subzero/src/IceInst.h - High-level instructions ----------*- C++ -*-===// 1 //===- subzero/src/IceInst.h - High-level instructions ----------*- C++ -*-===//
2 // 2 //
3 // The Subzero Code Generator 3 // The Subzero Code Generator
4 // 4 //
5 // This file is distributed under the University of Illinois Open Source 5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details. 6 // License. See LICENSE.TXT for details.
7 // 7 //
8 //===----------------------------------------------------------------------===// 8 //===----------------------------------------------------------------------===//
9 /// 9 ///
10 /// \file 10 /// \file
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 } 158 }
159 virtual void emitIAS(const Cfg *Func) const { emit(Func); } 159 virtual void emitIAS(const Cfg *Func) const { emit(Func); }
160 virtual void dump(const Cfg *Func) const; 160 virtual void dump(const Cfg *Func) const;
161 virtual void dumpExtras(const Cfg *Func) const; 161 virtual void dumpExtras(const Cfg *Func) const;
162 void dumpDecorated(const Cfg *Func) const; 162 void dumpDecorated(const Cfg *Func) const;
163 void emitSources(const Cfg *Func) const; 163 void emitSources(const Cfg *Func) const;
164 void dumpSources(const Cfg *Func) const; 164 void dumpSources(const Cfg *Func) const;
165 void dumpDest(const Cfg *Func) const; 165 void dumpDest(const Cfg *Func) const;
166 virtual bool isRedundantAssign() const { return false; } 166 virtual bool isRedundantAssign() const { return false; }
167 167
168 ~Inst() = default; 168 virtual ~Inst() = default;
169 169
170 protected: 170 protected:
171 Inst(Cfg *Func, InstKind Kind, SizeT MaxSrcs, Variable *Dest); 171 Inst(Cfg *Func, InstKind Kind, SizeT MaxSrcs, Variable *Dest);
172 void addSource(Operand *Src) { 172 void addSource(Operand *Src) {
173 assert(Src); 173 assert(Src);
174 assert(NumSrcs < MaxSrcs); 174 assert(NumSrcs < MaxSrcs);
175 Srcs[NumSrcs++] = Src; 175 Srcs[NumSrcs++] = Src;
176 } 176 }
177 void setLastUse(SizeT VarIndex) { 177 void setLastUse(SizeT VarIndex) {
178 if (VarIndex < CHAR_BIT * sizeof(LiveRangesEnded)) 178 if (VarIndex < CHAR_BIT * sizeof(LiveRangesEnded))
(...skipping 818 matching lines...) Expand 10 before | Expand all | Expand 10 after
997 static void noteHead(Ice::Inst *, Ice::Inst *) {} 997 static void noteHead(Ice::Inst *, Ice::Inst *) {}
998 void deleteNode(Ice::Inst *) {} 998 void deleteNode(Ice::Inst *) {}
999 999
1000 private: 1000 private:
1001 mutable ilist_half_node<Ice::Inst> Sentinel; 1001 mutable ilist_half_node<Ice::Inst> Sentinel;
1002 }; 1002 };
1003 1003
1004 } // end of namespace llvm 1004 } // end of namespace llvm
1005 1005
1006 #endif // SUBZERO_SRC_ICEINST_H 1006 #endif // SUBZERO_SRC_ICEINST_H
OLDNEW
« no previous file with comments | « src/IceFixups.h ('k') | src/IceOperand.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698