Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: src/IceOperand.h

Issue 1741733003: Fix clang warning "has virtual functions but non-virtual destructor". (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/IceInst.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 //===- subzero/src/IceOperand.h - High-level operands -----------*- C++ -*-===// 1 //===- subzero/src/IceOperand.h - High-level operands -----------*- C++ -*-===//
2 // 2 //
3 // The Subzero Code Generator 3 // The Subzero Code Generator
4 // 4 //
5 // This file is distributed under the University of Illinois Open Source 5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details. 6 // License. See LICENSE.TXT for details.
7 // 7 //
8 //===----------------------------------------------------------------------===// 8 //===----------------------------------------------------------------------===//
9 /// 9 ///
10 /// \file 10 /// \file
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 return; 84 return;
85 assert(Func); 85 assert(Func);
86 dump(Func, Func->getContext()->getStrDump()); 86 dump(Func, Func->getContext()->getStrDump());
87 } 87 }
88 void dump(Ostream &Str) const { 88 void dump(Ostream &Str) const {
89 if (BuildDefs::dump()) 89 if (BuildDefs::dump())
90 dump(nullptr, Str); 90 dump(nullptr, Str);
91 } 91 }
92 /// @} 92 /// @}
93 93
94 ~Operand() = default; 94 virtual ~Operand() = default;
95 95
96 protected: 96 protected:
97 Operand(OperandKind Kind, Type Ty) : Ty(Ty), Kind(Kind) { 97 Operand(OperandKind Kind, Type Ty) : Ty(Ty), Kind(Kind) {
98 // It is undefined behavior to have a larger value in the enum 98 // It is undefined behavior to have a larger value in the enum
99 assert(Kind <= kTarget_Max); 99 assert(Kind <= kTarget_Max);
100 } 100 }
101 101
102 const Type Ty; 102 const Type Ty;
103 const OperandKind Kind; 103 const OperandKind Kind;
104 /// Vars and NumVars are initialized by the derived class. 104 /// Vars and NumVars are initialized by the derived class.
(...skipping 828 matching lines...) Expand 10 before | Expand all | Expand 10 after
933 private: 933 private:
934 const Cfg *Func; 934 const Cfg *Func;
935 MetadataKind Kind; 935 MetadataKind Kind;
936 CfgVector<VariableTracking> Metadata; 936 CfgVector<VariableTracking> Metadata;
937 const static InstDefList NoDefinitions; 937 const static InstDefList NoDefinitions;
938 }; 938 };
939 939
940 } // end of namespace Ice 940 } // end of namespace Ice
941 941
942 #endif // SUBZERO_SRC_ICEOPERAND_H 942 #endif // SUBZERO_SRC_ICEOPERAND_H
OLDNEW
« no previous file with comments | « src/IceInst.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698