Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: extensions/common/value_builder_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/value_builder_unittest.cc
diff --git a/extensions/common/value_builder_unittest.cc b/extensions/common/value_builder_unittest.cc
index 7c474511b23bd20029b81d8bc08dd9f99263d50f..1f1c14e1abdaea74d97f13bab3da7b206208ae4a 100644
--- a/extensions/common/value_builder_unittest.cc
+++ b/extensions/common/value_builder_unittest.cc
@@ -20,9 +20,8 @@ TEST(ValueBuilderTest, Basic) {
scoped_ptr<base::DictionaryValue> settings(new base::DictionaryValue);
ASSERT_FALSE(settings->GetList("permissions", nullptr));
- settings = DictionaryBuilder()
- .Set("permissions", std::move(permission_list))
- .Build();
+ settings =
+ DictionaryBuilder().Set("permissions", permission_list.Build()).Build();
base::ListValue* list_value;
ASSERT_TRUE(settings->GetList("permissions", &list_value));

Powered by Google App Engine
This is Rietveld 408576698