chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc - Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc ('k') | chrome/browser/extensions/activity_log/activity_log_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc

diff --git a/chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc b/chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc

index 6501a4672848353ba094eea899716ade24b96187..421f55a920170cc92a2ca21b80a7921dcf025bde 100644

--- a/chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc

+++ b/chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc

@@ -49,9 +49,8 @@ TEST_F(ActivityLogPolicyUtilTest, StripPrivacySensitiveWebRequest) {

.Set(activity_log_web_request_constants::kNewUrlKey,

"http://www.youtube.com/")

.Set(activity_log_web_request_constants::kAddedRequestHeadersKey,

- std::move(ListBuilder().Append("arg")))

- .Build()

- .release());

Nico 2016/02/27 03:33:00 did you drop the release() intentionally?

dcheng 2016/02/27 03:39:30 Yep, this method has two overloads: a scoped_ptr o

+ ListBuilder().Append("arg").Build())

+ .Build());

ActivityLogPolicy::Util::StripPrivacySensitiveFields(action);