extensions/shell/browser/api/identity/identity_api_unittest.cc - Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/api/identity/identity_api_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc ('K') | « extensions/common/value_builder_unittest.cc ('k') | extensions/shell/browser/shell_native_app_window_aura_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/shell/browser/api/identity/identity_api_unittest.cc

diff --git a/extensions/shell/browser/api/identity/identity_api_unittest.cc b/extensions/shell/browser/api/identity/identity_api_unittest.cc

index bf9248ccd5d2bf3b5a3d11b768331c11d0ed43ba..0af6e4b13bbb46a23cfce6bb9bf41aae453fe5a7 100644

--- a/extensions/shell/browser/api/identity/identity_api_unittest.cc

+++ b/extensions/shell/browser/api/identity/identity_api_unittest.cc

@@ -65,18 +65,21 @@ class IdentityApiTest : public ApiUnitTest {

// Create an extension with OAuth2 scopes.

set_extension(

ExtensionBuilder()

- .SetManifest(std::move(

+ .SetManifest(

DictionaryBuilder()

.Set("name", "Test")

.Set("version", "1.0")

.Set("oauth2",

- std::move(DictionaryBuilder()

- .Set("client_id",

- "123456.apps.googleusercontent.com")

- .Set("scopes",

- std::move(ListBuilder().Append(

- "https://www.googleapis.com/"

- "auth/drive")))))))

+ DictionaryBuilder()

+ .Set("client_id",

+ "123456.apps.googleusercontent.com")

+ .Set("scopes",

+ ListBuilder()

+ .Append("https://www.googleapis.com/"

+ "auth/drive")

+ .Build())

.SetLocation(Manifest::UNPACKED)

.Build());

}