Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1187)

Side by Side Diff: extensions/common/value_builder_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <utility> 5 #include <utility>
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "extensions/common/value_builder.h" 9 #include "extensions/common/value_builder.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 11
12 using ValueBuilderTest = testing::Test; 12 using ValueBuilderTest = testing::Test;
13 13
14 namespace extensions { 14 namespace extensions {
15 15
16 TEST(ValueBuilderTest, Basic) { 16 TEST(ValueBuilderTest, Basic) {
17 ListBuilder permission_list; 17 ListBuilder permission_list;
18 permission_list.Append("tabs").Append("history"); 18 permission_list.Append("tabs").Append("history");
19 19
20 scoped_ptr<base::DictionaryValue> settings(new base::DictionaryValue); 20 scoped_ptr<base::DictionaryValue> settings(new base::DictionaryValue);
21 21
22 ASSERT_FALSE(settings->GetList("permissions", nullptr)); 22 ASSERT_FALSE(settings->GetList("permissions", nullptr));
23 settings = DictionaryBuilder() 23 settings =
24 .Set("permissions", std::move(permission_list)) 24 DictionaryBuilder().Set("permissions", permission_list.Build()).Build();
25 .Build();
26 base::ListValue* list_value; 25 base::ListValue* list_value;
27 ASSERT_TRUE(settings->GetList("permissions", &list_value)); 26 ASSERT_TRUE(settings->GetList("permissions", &list_value));
28 27
29 ASSERT_EQ(2U, list_value->GetSize()); 28 ASSERT_EQ(2U, list_value->GetSize());
30 std::string permission; 29 std::string permission;
31 ASSERT_TRUE(list_value->GetString(0, &permission)); 30 ASSERT_TRUE(list_value->GetString(0, &permission));
32 ASSERT_EQ(permission, "tabs"); 31 ASSERT_EQ(permission, "tabs");
33 ASSERT_TRUE(list_value->GetString(1, &permission)); 32 ASSERT_TRUE(list_value->GetString(1, &permission));
34 ASSERT_EQ(permission, "history"); 33 ASSERT_EQ(permission, "history");
35 } 34 }
36 35
37 } // namespace extensions 36 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698