Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: extensions/common/value_builder.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/value_builder.cc
diff --git a/extensions/common/value_builder.cc b/extensions/common/value_builder.cc
index 987bbb47b04a1f12d1d30ebb3d3dd9e6ae4d296e..efc2e44fad3e49602083897f0449a0876f55b47b 100644
--- a/extensions/common/value_builder.cc
+++ b/extensions/common/value_builder.cc
@@ -20,14 +20,6 @@ DictionaryBuilder::DictionaryBuilder(const base::DictionaryValue& init)
DictionaryBuilder::~DictionaryBuilder() {}
-DictionaryBuilder::DictionaryBuilder(DictionaryBuilder&& other)
- : dict_(other.Build()) {}
-
-DictionaryBuilder& DictionaryBuilder::operator=(DictionaryBuilder&& other) {
- dict_ = other.Build();
- return *this;
-}
-
std::string DictionaryBuilder::ToJSON() const {
std::string json;
base::JSONWriter::WriteWithOptions(
@@ -60,18 +52,6 @@ DictionaryBuilder& DictionaryBuilder::Set(const std::string& path,
}
DictionaryBuilder& DictionaryBuilder::Set(const std::string& path,
- DictionaryBuilder in_value) {
- dict_->SetWithoutPathExpansion(path, in_value.Build());
- return *this;
-}
-
-DictionaryBuilder& DictionaryBuilder::Set(const std::string& path,
- ListBuilder in_value) {
- dict_->SetWithoutPathExpansion(path, in_value.Build());
- return *this;
-}
-
-DictionaryBuilder& DictionaryBuilder::Set(const std::string& path,
scoped_ptr<base::Value> in_value) {
dict_->SetWithoutPathExpansion(path, std::move(in_value));
return *this;
@@ -90,14 +70,6 @@ ListBuilder::ListBuilder(const base::ListValue& init) : list_(init.DeepCopy()) {
}
ListBuilder::~ListBuilder() {}
-ListBuilder::ListBuilder(ListBuilder&& other)
- : list_(other.Build()) {}
-
-ListBuilder& ListBuilder::operator=(ListBuilder&& other) {
- list_ = other.Build();
- return *this;
-}
-
ListBuilder& ListBuilder::Append(int in_value) {
list_->Append(new base::FundamentalValue(in_value));
return *this;
@@ -118,13 +90,8 @@ ListBuilder& ListBuilder::Append(const base::string16& in_value) {
return *this;
}
-ListBuilder& ListBuilder::Append(DictionaryBuilder in_value) {
- list_->Append(in_value.Build());
- return *this;
-}
-
-ListBuilder& ListBuilder::Append(ListBuilder in_value) {
- list_->Append(in_value.Build());
+ListBuilder& ListBuilder::Append(scoped_ptr<base::Value> in_value) {
+ list_->Append(std::move(in_value));
return *this;
}

Powered by Google App Engine
This is Rietveld 408576698