Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1738613002: Rename enums/functions that collide in chromium style in core/dom/ (Closed)

Created:
4 years, 10 months ago by danakj
Modified:
4 years, 10 months ago
Reviewers:
haraken, pdr., esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, dcheng, devtools-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, gavinp+loader_chromium.org, gavinp+prerender_chromium.org, hongchan, Nate Chapin, jchaffraix+rendering, kinuko+watch, kozyatinskiy+blink_chromium.org, leviw+renderwatch, loading-reviews_chromium.org, lushnikov+blink_chromium.org, mkwst+watchlist-csp_chromium.org, mlamouri+watch-blink_chromium.org, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, piman, rwlbuis, Raymond Toy, sergeyv+blink_chromium.org, sof, szager+layoutwatch_chromium.org, Nico, tyoshino+watch_chromium.org, webcomponents-bugzilla_chromium.org, yhirano+watch_chromium.org, Yoav Weiss, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@get-names-3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename enums/functions that collide in chromium style in core/dom/ R=esprehn@chromium.org, pdr BUG=582312 Committed: https://crrev.com/bda5037a1df2390c268493f608ca9b88b38ca715 Cr-Commit-Position: refs/heads/master@{#377546}

Patch Set 1 : get-names-4: #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -224 lines) Patch
M third_party/WebKit/Source/core/css/CSSStyleSheet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/StyleRuleImport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserMode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Attr.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/CDATASection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CDATASection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/CharacterData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Comment.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Comment.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 13 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentFragment.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentFragment.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentInit.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentInit.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentLifecycle.h View 5 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 4 chunks +6 lines, -6 lines 1 comment Download
M third_party/WebKit/Source/core/dom/Node.cpp View 14 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/NodeIteratorBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ProcessingInstruction.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Range.cpp View 12 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptableDocumentParser.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/SecurityContext.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Text.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Text.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/InsertionPoint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/MarkupAccumulator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/Serialization.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameOwner.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLBodyElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTablePartElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/TextDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/DOMPatchSupport.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PrerenderHandle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/CreateWindow.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/xml/DocumentXSLT.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XPathFunctions.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XPathStep.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathUtil.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNode.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNode.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ContextMenuClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/RemoteBridgeFrameOwner.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebNode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (7 generated)
danakj
4 years, 10 months ago (2016-02-25 00:58:59 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738613002/1
4 years, 10 months ago (2016-02-25 01:03:20 UTC) #3
pdr.
LGTM https://codereview.chromium.org/1738613002/diff/1/third_party/WebKit/Source/core/dom/Node.h File third_party/WebKit/Source/core/dom/Node.h (right): https://codereview.chromium.org/1738613002/diff/1/third_party/WebKit/Source/core/dom/Node.h#newcode207 third_party/WebKit/Source/core/dom/Node.h:207: virtual NodeType getNodeType() const = 0; This one ...
4 years, 10 months ago (2016-02-25 01:11:30 UTC) #4
danakj
+haraken@chromium.org for modules/
4 years, 10 months ago (2016-02-25 01:12:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738613002/1
4 years, 10 months ago (2016-02-25 01:18:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/149889)
4 years, 10 months ago (2016-02-25 01:29:31 UTC) #11
haraken
LGTM
4 years, 10 months ago (2016-02-25 09:16:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738613002/1
4 years, 10 months ago (2016-02-25 09:18:02 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 10:23:02 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 10:24:31 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bda5037a1df2390c268493f608ca9b88b38ca715
Cr-Commit-Position: refs/heads/master@{#377546}

Powered by Google App Engine
This is Rietveld 408576698