Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Issue 1729013002: blink: Rename enums and functions to not collide with chromium style. (Closed)

Created:
4 years, 10 months ago by danakj
Modified:
4 years, 10 months ago
Reviewers:
pdr., esprehn
CC:
chromium-reviews, shans, dshwang, fs, apavlov+blink_chromium.org, kouhei+svg_chromium.org, rwlbuis, Yoav Weiss, krit, blink-reviews-css, dglazkov+blink, blink-reviews-paint_chromium.org, blink-reviews, gyuyoung2, pdr+svgwatchlist_chromium.org, Eric Willigers, kenneth.christiansen, rjwright, blink-reviews-style_chromium.org, darktears, blink-reviews-animation_chromium.org, slimming-paint-reviews_chromium.org, f(malita), Stephen Chennney, dcheng, piman, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blink: Rename enums and functions to not collide with chromium style. This fixes collisions in core/css/. R=esprehn@chromium.org, pdr BUG=582312 Committed: https://crrev.com/52140a12641d98d1d840392ba2bae4a9dd31e9b6 Cr-Commit-Position: refs/heads/master@{#377432}

Patch Set 1 #

Patch Set 2 : get-names-3: . #

Patch Set 3 : get-names-3: . #

Patch Set 4 : get-names-3: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -90 lines) Patch
M third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFace.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFace.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPropertySourceData.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSValue.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/css/ElementRuleCollector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/MediaQuery.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQuery.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/RuleSet.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/StyleColor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleRule.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserObserver.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserToken.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserTokenRange.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSTokenizerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSVariableParser.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/MediaQueryBlockWatcher.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/MediaQueryParser.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/MediaQueryParser.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TextPainterTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedColor.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
danakj
4 years, 10 months ago (2016-02-24 02:12:50 UTC) #2
pdr.
These names seem reasonable too. LGTM
4 years, 10 months ago (2016-02-24 03:45:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729013002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729013002/40001
4 years, 10 months ago (2016-02-24 20:58:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/26626) cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-24 21:17:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729013002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729013002/80001
4 years, 10 months ago (2016-02-24 22:52:19 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 10 months ago (2016-02-25 00:13:34 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 00:15:37 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/52140a12641d98d1d840392ba2bae4a9dd31e9b6
Cr-Commit-Position: refs/heads/master@{#377432}

Powered by Google App Engine
This is Rietveld 408576698