Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 1738623004: Rename enums/functions that collide in chromium style. (Closed)

Created:
4 years, 10 months ago by danakj
Modified:
4 years, 10 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-events_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, blink-reviews-w3ctests_chromium.org, caseq+blink_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dcheng, devtools-reviews_chromium.org, dglazkov+blink, krit, eae+blinkwatch, f(malita), fs, gavinp+prerender_chromium.org, gavinp+loader_chromium.org, gyuyoung2, jam, Nate Chapin, jchaffraix+rendering, kinuko+watch, kinuko+fileapi, kouhei+svg_chromium.org, kozyatinskiy+blink_chromium.org, leviw+renderwatch, loading-reviews_chromium.org, loading-reviews+fetch_chromium.org, lushnikov+blink_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+watchlist-csp_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nhiroki, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, pfeldman+blink_chromium.org, piman, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, sof, szager+layoutwatch_chromium.org, tfarina, Nico, tyoshino+watch_chromium.org, tzik, Yoav Weiss, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@get-names-4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename enums/functions that collide in chromium style. This fixes cases in: core/editing/ core/events/ core/fetch/ core/fileapi/ core/frame/ TBR=esprehn, Nico, sievers, haraken R=esprehn@chromium.org, pdr BUG=582312 Committed: https://crrev.com/846b7985fcb118a36f9b44679bc02488f3019d94 Cr-Commit-Position: refs/heads/master@{#377812}

Patch Set 1 : get-names-5 #

Total comments: 3

Patch Set 2 : get-names-5: rebase-and-stuff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -200 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_url_request_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataObjectTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/CaretBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PendingSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventListener.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/events/MessageEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/MessageEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/WheelEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/WheelEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/DocumentResource.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/DocumentResource.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/FetchContext.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/FetchContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/FetchRequest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/FontResource.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResourceClient.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/MemoryCache.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/RawResource.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 1 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceClient.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 20 chunks +29 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ScriptResource.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/StyleSheetResourceClient.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/File.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElementTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLSrcsetParserTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/PreloadRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchRequestData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Request.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMFileSystemBaseTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/FileWriter.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/FileWriter.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PlatformWheelEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Prerender.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebPrerender.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLRequest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceRequest.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceRequestTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 9 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLRequest.h View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (10 generated)
danakj
I think these are all just adding get__. FileWriter and FileReader required IDL to mention ...
4 years, 10 months ago (2016-02-25 19:25:05 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738623004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738623004/1
4 years, 10 months ago (2016-02-25 19:29:43 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/27433) android_chromium_gn_compile_rel on ...
4 years, 10 months ago (2016-02-25 19:37:49 UTC) #5
tkent
https://codereview.chromium.org/1738623004/diff/1/third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/idlharness.idl File third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/idlharness.idl (right): https://codereview.chromium.org/1738623004/diff/1/third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/idlharness.idl#newcode58 third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/idlharness.idl:58: [ImplementedAs=getReadyState] readonly attribute unsigned short readyState; This is an ...
4 years, 10 months ago (2016-02-25 23:13:09 UTC) #6
danakj
Rebased also. https://codereview.chromium.org/1738623004/diff/1/third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/idlharness.idl File third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/idlharness.idl (right): https://codereview.chromium.org/1738623004/diff/1/third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/idlharness.idl#newcode58 third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/idlharness.idl:58: [ImplementedAs=getReadyState] readonly attribute unsigned short readyState; On ...
4 years, 10 months ago (2016-02-25 23:27:04 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738623004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738623004/20001
4 years, 10 months ago (2016-02-25 23:33:28 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/27733)
4 years, 10 months ago (2016-02-26 00:01:06 UTC) #11
tkent
third_party/WebKit lgtm
4 years, 10 months ago (2016-02-26 00:51:21 UTC) #13
pdr.
LGTM here too https://codereview.chromium.org/1738623004/diff/1/third_party/WebKit/Source/core/editing/CaretBase.h File third_party/WebKit/Source/core/editing/CaretBase.h (right): https://codereview.chromium.org/1738623004/diff/1/third_party/WebKit/Source/core/editing/CaretBase.h#newcode66 third_party/WebKit/Source/core/editing/CaretBase.h:66: CaretVisibility getCaretVisibility() const { return m_caretVisibility; ...
4 years, 10 months ago (2016-02-26 01:17:10 UTC) #14
pdr.
On 2016/02/26 at 01:17:10, pdr wrote: > LGTM here too > > https://codereview.chromium.org/1738623004/diff/1/third_party/WebKit/Source/core/editing/CaretBase.h > File ...
4 years, 10 months ago (2016-02-26 01:17:51 UTC) #15
danakj
TBR'ing folks for remaining directories as it's mechanical.
4 years, 10 months ago (2016-02-26 02:43:22 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738623004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738623004/20001
4 years, 10 months ago (2016-02-26 02:47:42 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-26 04:44:11 UTC) #22
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/846b7985fcb118a36f9b44679bc02488f3019d94 Cr-Commit-Position: refs/heads/master@{#377812}
4 years, 10 months ago (2016-02-26 04:45:18 UTC) #24
haraken
4 years, 10 months ago (2016-02-26 08:33:15 UTC) #25
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698