third_party/WebKit/Source/core/dom/Attr.h - Issue 1738613002: Rename enums/functions that collide in chromium style in core/dom/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Attr.h

Issue 1738613002: Rename enums/functions that collide in chromium style in core/dom/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@get-names-3

Patch Set: get-names-4: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSParserMode.cpp ('k') | third_party/WebKit/Source/core/dom/CDATASection.h » ('j') | third_party/WebKit/Source/core/dom/Node.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Attr.h

diff --git a/third_party/WebKit/Source/core/dom/Attr.h b/third_party/WebKit/Source/core/dom/Attr.h

index 9bfd82932a6fc1dcf00bbab7a9fbc23126406a54..3fdd0e99e772e4c0b5defb5a239aba7099bd607d 100644

--- a/third_party/WebKit/Source/core/dom/Attr.h

+++ b/third_party/WebKit/Source/core/dom/Attr.h

@@ -66,7 +66,7 @@ private:

bool isElementNode() const = delete; // This will catch anyone doing an unnecessary check.

String nodeName() const override { return name(); }

- NodeType nodeType() const override { return ATTRIBUTE_NODE; }

+ NodeType getNodeType() const override { return ATTRIBUTE_NODE; }

String nodeValue() const override { return value(); }

void setNodeValue(const String&) override;