bluetooth: Add Web Bluetooth blacklist checks to readValue & writeValue.

bluetooth: Add Web Bluetooth blacklist checks to readValue & writeValue.

Disallow access to read and write partially blacklisted characteristics,
as per Web Bluetooth specification:
https://webbluetoothcg.github.io/web-bluetooth/#the-gatt-blacklist

Test data specification will be updated to match this change.
Issue https://github.com/WebBluetoothCG/web-bluetooth/issues/214
has been updated with changes in this patch.

To facilitate testing, random UUIDs are added in bluetooth_blacklist.cc
for object permutations that don't exist in the specified blacklist
registry.

BUG=584398
Committed: https://crrev.com/dbd2cee52c8cbaa4bdec4e08b04464e3563d338c
Cr-Commit-Position: refs/heads/master@{#377931}

[scheib, 2016-02-25 23:14:24]

Description was changed from

==========
bluetooth: Add Web Bluetooth blacklist checks to readValue & writeValue.

Disallow access to read and write partially blacklisted characteristics,
as per Web Bluetooth specification:
https://webbluetoothcg.github.io/web-bluetooth/#the-gatt-blacklist

Test data specification will be updated to match this change.
Issue https://github.com/WebBluetoothCG/web-bluetooth/issues/214
has been updated with changes in this patch.

BUG=584398
==========

to

==========
bluetooth: Add Web Bluetooth blacklist checks to readValue & writeValue.

Disallow access to read and write partially blacklisted characteristics,
as per Web Bluetooth specification:
https://webbluetoothcg.github.io/web-bluetooth/#the-gatt-blacklist

Test data specification will be updated to match this change.
Issue https://github.com/WebBluetoothCG/web-bluetooth/issues/214
has been updated with changes in this patch.

To facilitate testing, random UUIDs are added in bluetooth_blacklist.cc
for object permutations that don't exist in the specified blacklist
registry.

BUG=584398
==========

[scheib, 2016-02-25 23:27:32]

scheib@chromium.org changed reviewers:
+ ortuno@chromium.org

[ortuno, 2016-02-26 00:07:11]

lgtm

https://codereview.chromium.org/1737423002/diff/20001/content/browser/bluetoo...
File content/browser/bluetooth/bluetooth_dispatcher_host.cc (right):

https://codereview.chromium.org/1737423002/diff/20001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:871:
RecordCharacteristicReadValueOutcome(UMAGATTOperationOutcome::BLACKLISTED);
Any reason why you put read/write in the same histogram?

https://codereview.chromium.org/1737423002/diff/20001/content/shell/browser/l...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
(right):

https://codereview.chromium.org/1737423002/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc:79:
const char kPeripheralPrivacyFlagUUID[] = "2A02";
lower case: 2a02

https://codereview.chromium.org/1737423002/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc:788:
{  // Device Name:
Why add the scope here? None of the other functions have it and I don't see that
much benefit.

https://codereview.chromium.org/1737423002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/bluetooth/readValue-blacklist.html (right):

https://codereview.chromium.org/1737423002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/bluetooth/readValue-blacklist.html:20:
.then(characteristic => Promise.all(
fwiw this wouldn't work on a real device, since you can't do two gatt operations
at the same time.

[scheib, 2016-02-26 00:49:08]

Patchset #3 (id:30001) has been deleted

[scheib, 2016-02-26 00:49:32]

The CQ bit was checked by scheib@chromium.org

[scheib, 2016-02-26 00:49:33]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org
Link to the patchset: https://codereview.chromium.org/1737423002/#ps50001
(title: "addressed ortuno")

[scheib, 2016-02-26 00:49:49]

Thanks,

https://codereview.chromium.org/1737423002/diff/20001/content/browser/bluetoo...
File content/browser/bluetooth/bluetooth_dispatcher_host.cc (right):

https://codereview.chromium.org/1737423002/diff/20001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:871:
RecordCharacteristicReadValueOutcome(UMAGATTOperationOutcome::BLACKLISTED);
On 2016/02/26 00:07:11, ortuno wrote:
> Any reason why you put read/write in the same histogram?

Same histogram enumeration, but different histogram names. (no code change)

https://codereview.chromium.org/1737423002/diff/20001/content/shell/browser/l...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
(right):

https://codereview.chromium.org/1737423002/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc:79:
const char kPeripheralPrivacyFlagUUID[] = "2A02";
On 2016/02/26 00:07:11, ortuno wrote:
> lower case: 2a02

Done.

https://codereview.chromium.org/1737423002/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc:788:
{  // Device Name:
On 2016/02/26 00:07:11, ortuno wrote:
> Why add the scope here? None of the other functions have it and I don't see
that
> much benefit.

Mainly to visually group the related code blocks. Because the 'blocks' have
useful 'sub-blocks' it doesn't work to only have a comment header and then
several lines of code visually broken up by another comment line.

In other situations would keep local variables scoped, but that's not why in
this case.

https://codereview.chromium.org/1737423002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/bluetooth/readValue-blacklist.html (right):

https://codereview.chromium.org/1737423002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/bluetooth/readValue-blacklist.html:20:
.then(characteristic => Promise.all(
On 2016/02/26 00:07:11, ortuno wrote:
> fwiw this wouldn't work on a real device, since you can't do two gatt
operations
> at the same time.

Done.

[scheib, 2016-02-26 00:50:29]

The CQ bit was unchecked by scheib@chromium.org

[scheib, 2016-02-26 00:51:07]

scheib@chromium.org changed reviewers:
+ isherman@chromium.org

[scheib, 2016-02-26 00:51:08]

isherman: PTAL: histograms.xml

[Ilya Sherman, 2016-02-26 01:08:16]

histograms.xml lgtm

[scheib, 2016-02-26 01:20:47]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2016-02-26 01:25:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1737423002/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1737423002/50001

[commit-bot: I haz the power, 2016-02-26 01:43:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 01:43:19]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[scheib, 2016-02-26 03:47:12]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2016-02-26 03:50:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1737423002/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1737423002/50001

[commit-bot: I haz the power, 2016-02-26 06:07:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 06:07:59]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scheib, 2016-02-26 18:21:54]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2016-02-26 18:25:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1737423002/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1737423002/50001

[commit-bot: I haz the power, 2016-02-26 18:38:26]

Description was changed from

==========
bluetooth: Add Web Bluetooth blacklist checks to readValue & writeValue.

Disallow access to read and write partially blacklisted characteristics,
as per Web Bluetooth specification:
https://webbluetoothcg.github.io/web-bluetooth/#the-gatt-blacklist

Test data specification will be updated to match this change.
Issue https://github.com/WebBluetoothCG/web-bluetooth/issues/214
has been updated with changes in this patch.

To facilitate testing, random UUIDs are added in bluetooth_blacklist.cc
for object permutations that don't exist in the specified blacklist
registry.

BUG=584398
==========

to

==========
bluetooth: Add Web Bluetooth blacklist checks to readValue & writeValue.

Disallow access to read and write partially blacklisted characteristics,
as per Web Bluetooth specification:
https://webbluetoothcg.github.io/web-bluetooth/#the-gatt-blacklist

Test data specification will be updated to match this change.
Issue https://github.com/WebBluetoothCG/web-bluetooth/issues/214
has been updated with changes in this patch.

To facilitate testing, random UUIDs are added in bluetooth_blacklist.cc
for object permutations that don't exist in the specified blacklist
registry.

BUG=584398
==========

[commit-bot: I haz the power, 2016-02-26 18:38:28]

Committed patchset #3 (id:50001)

[commit-bot: I haz the power, 2016-02-26 18:40:09]

Description was changed from

==========
bluetooth: Add Web Bluetooth blacklist checks to readValue & writeValue.

Disallow access to read and write partially blacklisted characteristics,
as per Web Bluetooth specification:
https://webbluetoothcg.github.io/web-bluetooth/#the-gatt-blacklist

Test data specification will be updated to match this change.
Issue https://github.com/WebBluetoothCG/web-bluetooth/issues/214
has been updated with changes in this patch.

To facilitate testing, random UUIDs are added in bluetooth_blacklist.cc
for object permutations that don't exist in the specified blacklist
registry.

BUG=584398
==========

to

==========
bluetooth: Add Web Bluetooth blacklist checks to readValue & writeValue.

Disallow access to read and write partially blacklisted characteristics,
as per Web Bluetooth specification:
https://webbluetoothcg.github.io/web-bluetooth/#the-gatt-blacklist

Test data specification will be updated to match this change.
Issue https://github.com/WebBluetoothCG/web-bluetooth/issues/214
has been updated with changes in this patch.

To facilitate testing, random UUIDs are added in bluetooth_blacklist.cc
for object permutations that don't exist in the specified blacklist
registry.

BUG=584398

Committed: https://crrev.com/dbd2cee52c8cbaa4bdec4e08b04464e3563d338c
Cr-Commit-Position: refs/heads/master@{#377931}
==========

[commit-bot: I haz the power, 2016-02-26 18:40:10]

Patchset 3 (id:??) landed as
https://crrev.com/dbd2cee52c8cbaa4bdec4e08b04464e3563d338c
Cr-Commit-Position: refs/heads/master@{#377931}