Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp

Issue 1737423002: bluetooth: Add Web Bluetooth blacklist checks to readValue & writeValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bt-blacklist-char-
Patch Set: addressed ortuno Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/bluetooth/BluetoothError.h" 5 #include "modules/bluetooth/BluetoothError.h"
6 6
7 #include "core/dom/DOMException.h" 7 #include "core/dom/DOMException.h"
8 #include "core/dom/ExceptionCode.h" 8 #include "core/dom/ExceptionCode.h"
9 9
10 namespace blink { 10 namespace blink {
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 // NotSupportedErrors: 55 // NotSupportedErrors:
56 MAP_ERROR(GATTUnknownError, NotSupportedError, "GATT Error Unknown."); 56 MAP_ERROR(GATTUnknownError, NotSupportedError, "GATT Error Unknown.");
57 MAP_ERROR(GATTUnknownFailure, NotSupportedError, "GATT operation failed for unknown reason."); 57 MAP_ERROR(GATTUnknownFailure, NotSupportedError, "GATT operation failed for unknown reason.");
58 MAP_ERROR(GATTNotPermitted, NotSupportedError, "GATT operation not permi tted."); 58 MAP_ERROR(GATTNotPermitted, NotSupportedError, "GATT operation not permi tted.");
59 MAP_ERROR(GATTNotSupported, NotSupportedError, "GATT Error: Not supporte d."); 59 MAP_ERROR(GATTNotSupported, NotSupportedError, "GATT Error: Not supporte d.");
60 MAP_ERROR(GATTUntranslatedErrorCode, NotSupportedError, "GATT Error: Unk nown GattErrorCode."); 60 MAP_ERROR(GATTUntranslatedErrorCode, NotSupportedError, "GATT Error: Unk nown GattErrorCode.");
61 61
62 // SecurityErrors: 62 // SecurityErrors:
63 MAP_ERROR(GATTNotAuthorized, SecurityError, "GATT operation not authoriz ed."); 63 MAP_ERROR(GATTNotAuthorized, SecurityError, "GATT operation not authoriz ed.");
64 MAP_ERROR(BlacklistedCharacteristicUUID, SecurityError, "getCharacterist ic(s) called with blacklisted UUID. https://goo.gl/4NeimX"); 64 MAP_ERROR(BlacklistedCharacteristicUUID, SecurityError, "getCharacterist ic(s) called with blacklisted UUID. https://goo.gl/4NeimX");
65 MAP_ERROR(BlacklistedRead, SecurityError, "readValue() called on blackli sted object marked exclude-reads. https://goo.gl/4NeimX");
66 MAP_ERROR(BlacklistedWrite, SecurityError, "writeValue() called on black listed object marked exclude-writes. https://goo.gl/4NeimX");
65 MAP_ERROR(NotAllowedToAccessService, SecurityError, "Origin is not allow ed to access the service. Remember to add the service to a filter or to optional Services in requestDevice()."); 67 MAP_ERROR(NotAllowedToAccessService, SecurityError, "Origin is not allow ed to access the service. Remember to add the service to a filter or to optional Services in requestDevice().");
66 MAP_ERROR(RequestDeviceWithBlacklistedUUID, SecurityError, "requestDevic e() called with a filter containing a blacklisted UUID. https://goo.gl/4NeimX"); 68 MAP_ERROR(RequestDeviceWithBlacklistedUUID, SecurityError, "requestDevic e() called with a filter containing a blacklisted UUID. https://goo.gl/4NeimX");
67 MAP_ERROR(RequestDeviceWithUniqueOrigin, SecurityError, "requestDevice() called from sandboxed or otherwise unique origin."); 69 MAP_ERROR(RequestDeviceWithUniqueOrigin, SecurityError, "requestDevice() called from sandboxed or otherwise unique origin.");
68 MAP_ERROR(RequestDeviceWithoutFrame, SecurityError, "No window to show t he requestDevice() dialog."); 70 MAP_ERROR(RequestDeviceWithoutFrame, SecurityError, "No window to show t he requestDevice() dialog.");
69 71
70 #undef MAP_ERROR 72 #undef MAP_ERROR
71 } 73 }
72 74
73 ASSERT_NOT_REACHED(); 75 ASSERT_NOT_REACHED();
74 return DOMException::create(UnknownError); 76 return DOMException::create(UnknownError);
75 } 77 }
76 78
77 } // namespace blink 79 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698