third_party/WebKit/LayoutTests/bluetooth/readValue-blacklist.html - Issue 1737423002: bluetooth: Add Web Bluetooth blacklist checks to readValue & writeValue.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/readValue-blacklist.html

Issue 1737423002: bluetooth: Add Web Bluetooth blacklist checks to readValue & writeValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bt-blacklist-char-

Patch Set: explain testing UUIDs Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc ('K') | « third_party/WebKit/LayoutTests/bluetooth/getCharacteristic-blacklist.html ('k') | third_party/WebKit/LayoutTests/bluetooth/requestDevice-blacklist.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <script src="resources/bluetooth-helpers.js"></script>

	5 <script>

	6 'use strict';

	7

	8 test(t => { assert_true(window.testRunner instanceof Object); t.done(); },

	9 'window.testRunner is required for the following tests.');

	10

	11 promise_test(() => {

	12 testRunner.setBluetoothMockDataSet('BlacklistTestAdapter');

	13 return requestDeviceWithKeyDown(

	14 {filters: [{services: [blacklist_test_service_uuid]}]})

	15 .then(device => device.gatt.connect())

	16 .then(gattServer => gattServer.getPrimaryService(

	17 blacklist_test_service_uuid))

	18 .then(service => service.getCharacteristic(

	19 blacklist_exclude_reads_characteristic_uuid))

	20 .then(characteristic => Promise.all(
	ortuno 2016/02/26 00:07:11 fwiw this wouldn't work on a real device, since yo fwiw this wouldn't work on a real device, since you can't do two gatt operations at the same time. scheib 2016/02/26 00:49:49 Done. Show quoted text On 2016/02/26 00:07:11, ortuno wrote: > fwiw this wouldn't work on a real device, since you can't do two gatt operations > at the same time. Done.
	21 [characteristic.writeValue(new Uint8Array(1 /* length */)),

	22 assert_promise_rejects_with_message(

	23 characteristic.readValue(), new DOMException(

	24 'readValue() called on blacklisted object marked exclude-reads. ' +

	25 'https://goo.gl/4NeimX',

	26 'SecurityError'),

	27 'readValue() should reject.')

	28 ]));

	29 }, 'Characteristic with exclude-reads fullfills write and rejects read.');

	30 </script>

OLD	NEW