third_party/WebKit/LayoutTests/bluetooth/requestDevice-blacklist.html - Issue 1737423002: bluetooth: Add Web Bluetooth blacklist checks to readValue & writeValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/requestDevice-blacklist.html

Issue 1737423002: bluetooth: Add Web Bluetooth blacklist checks to readValue & writeValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bt-blacklist-char-

Patch Set: addressed ortuno Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/readValue-blacklist.html ('k') | third_party/WebKit/LayoutTests/bluetooth/resources/bluetooth-helpers.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/bluetooth/requestDevice-blacklist.html

diff --git a/third_party/WebKit/LayoutTests/bluetooth/requestDevice-blacklist.html b/third_party/WebKit/LayoutTests/bluetooth/requestDevice-blacklist.html

index 33527d2906687edb39ac5402b44e836b0899a5e9..f56046ef8ed5dd7e8e7b0aaa3ea49a7ed7dca608 100644

--- a/third_party/WebKit/LayoutTests/bluetooth/requestDevice-blacklist.html

+++ b/third_party/WebKit/LayoutTests/bluetooth/requestDevice-blacklist.html

@@ -10,7 +10,7 @@ test(t => { assert_true(window.testRunner instanceof Object); t.done(); },

'window.testRunner is required for the following tests.');

promise_test(() => {

- testRunner.setBluetoothMockDataSet('HeartRateAdapter');

+ testRunner.setBluetoothMockDataSet('BlacklistTestAdapter');

return assert_promise_rejects_with_message(

requestDeviceWithKeyDown(

{filters: [{services: ['human_interface_device']}]}),

@@ -22,10 +22,10 @@ promise_test(() => {

}, 'Reject with SecurityError if requesting a blacklisted service.');

promise_test(() => {

- testRunner.setBluetoothMockDataSet('HeartRateAndHIDAdapter');

+ testRunner.setBluetoothMockDataSet('BlacklistTestAdapter');

return requestDeviceWithKeyDown(

{

- filters: [{services: ['heart_rate']}],

+ filters: [{services: [blacklist_test_service_uuid]}],

optionalServices: ['human_interface_device']

})

.then(device => device.gatt.connect())