Factory methods for heap-allocated SkMaskFilter objects.

Factory methods for heap-allocated SkMaskFilter objects.

This is part of an effort to ensure that all SkPaint effects can only be
allocated on the heap.

This patch makes the constructors of SkMaskFilter and its subclasses non-public
and instead provides factory methods for  creating these objects on the heap. We
temporarily keep constructor of publicly visible classes public behind a flag.

BUG=skia:2187
Committed: http://code.google.com/p/skia/source/detail?r=13527

[Dominik Grewe, 2014-02-20 11:32:52]

Another patch to make sure paint effects can only be allocated on the heap. I've
left the constructor of SkBlurMaskFilterImpl (a subclass of SkMaskFilter) public
because it's only visible inside SkBlurMaskFilter.cpp and SkBlurMaskFilter (not
a subclass of SkMaskFilter) already has factory methods that return a pointer to
SkBlurMaskFilterImpl.

PTAL.

[scroggo, 2014-02-20 14:17:07]

https://codereview.chromium.org/173633003/diff/30001/include/effects/SkEmboss...
File include/effects/SkEmbossMaskFilter.h (right):

https://codereview.chromium.org/173633003/diff/30001/include/effects/SkEmboss...
include/effects/SkEmbossMaskFilter.h:31: static SkEmbossMaskFilter* Create(const
Light& light, SkScalar blurRadius) {
No need to create a factory for the deprecated constructor. I think the only
caller of this is in src/views/SkWidgets.cpp (in Skia; Chrome and Android do not
call it at all), which we should update to use the new version.

https://codereview.chromium.org/173633003/diff/30001/include/effects/SkEmboss...
include/effects/SkEmbossMaskFilter.h:53: SkEmbossMaskFilter(const Light& light,
SkScalar blurRadius);
This constructor can be removed entirely (once you update
src/views/SkWidgets.cpp).

https://codereview.chromium.org/173633003/diff/30001/include/effects/SkTableM...
File include/effects/SkTableMaskFilter.h (right):

https://codereview.chromium.org/173633003/diff/30001/include/effects/SkTableM...
include/effects/SkTableMaskFilter.h:59: SkTableMaskFilter(const uint8_t
table[256]);
Please add a factory for this constructor, which is called by Android.

[Dominik Grewe, 2014-02-20 16:38:10]

Thanks Leon!

https://codereview.chromium.org/173633003/diff/30001/include/effects/SkEmboss...
File include/effects/SkEmbossMaskFilter.h (right):

https://codereview.chromium.org/173633003/diff/30001/include/effects/SkEmboss...
include/effects/SkEmbossMaskFilter.h:31: static SkEmbossMaskFilter* Create(const
Light& light, SkScalar blurRadius) {
On 2014/02/20 14:17:07, scroggo wrote:
> No need to create a factory for the deprecated constructor. I think the only
> caller of this is in src/views/SkWidgets.cpp (in Skia; Chrome and Android do
not
> call it at all), which we should update to use the new version.

Done.

https://codereview.chromium.org/173633003/diff/30001/include/effects/SkEmboss...
include/effects/SkEmbossMaskFilter.h:53: SkEmbossMaskFilter(const Light& light,
SkScalar blurRadius);
On 2014/02/20 14:17:07, scroggo wrote:
> This constructor can be removed entirely (once you update
> src/views/SkWidgets.cpp).

Done.

https://codereview.chromium.org/173633003/diff/30001/include/effects/SkTableM...
File include/effects/SkTableMaskFilter.h (right):

https://codereview.chromium.org/173633003/diff/30001/include/effects/SkTableM...
include/effects/SkTableMaskFilter.h:59: SkTableMaskFilter(const uint8_t
table[256]);
On 2014/02/20 14:17:07, scroggo wrote:
> Please add a factory for this constructor, which is called by Android.

Good spot, thanks. I just assumed everyone only used the provided factory
methods.

[scroggo, 2014-02-20 16:40:07]

lgtm

[reed1, 2014-02-20 17:04:53]

lgtm

[Dominik Grewe, 2014-02-21 10:00:35]

The CQ bit was checked by dominikg@chromium.org

[commit-bot: I haz the power, 2014-02-21 10:00:39]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/dominikg@chromium.org/173633003/70001

[commit-bot: I haz the power, 2014-02-21 10:13:39]

Change committed as 13527