Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Side by Side Diff: include/effects/SkEmbossMaskFilter.h

Issue 173633003: Factory methods for heap-allocated SkMaskFilter objects. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Add SkTableMaskFilter::Create(table) and remove deprecated SkEmbossMaskFilter constructor. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « include/core/SkMaskFilter.h ('k') | include/effects/SkKernel33MaskFilter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2006 The Android Open Source Project 2 * Copyright 2006 The Android Open Source Project
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkEmbossMaskFilter_DEFINED 8 #ifndef SkEmbossMaskFilter_DEFINED
9 #define SkEmbossMaskFilter_DEFINED 9 #define SkEmbossMaskFilter_DEFINED
10 10
11 #include "SkMaskFilter.h" 11 #include "SkMaskFilter.h"
12 12
13 /** \class SkEmbossMaskFilter 13 /** \class SkEmbossMaskFilter
14 14
15 This mask filter creates a 3D emboss look, by specifying a light and blur am ount. 15 This mask filter creates a 3D emboss look, by specifying a light and blur am ount.
16 */ 16 */
17 class SK_API SkEmbossMaskFilter : public SkMaskFilter { 17 class SK_API SkEmbossMaskFilter : public SkMaskFilter {
18 public: 18 public:
19 struct Light { 19 struct Light {
20 SkScalar fDirection[3]; // x,y,z 20 SkScalar fDirection[3]; // x,y,z
21 uint16_t fPad; 21 uint16_t fPad;
22 uint8_t fAmbient; 22 uint8_t fAmbient;
23 uint8_t fSpecular; // exponent, 4.4 right now 23 uint8_t fSpecular; // exponent, 4.4 right now
24 }; 24 };
25 25
26 SkEmbossMaskFilter(SkScalar blurSigma, const Light& light); 26 static SkEmbossMaskFilter* Create(SkScalar blurSigma, const Light& light) {
27 27 return SkNEW_ARGS(SkEmbossMaskFilter, (blurSigma, light));
28 SK_ATTR_DEPRECATED("use sigma version") 28 }
29 SkEmbossMaskFilter(const Light& light, SkScalar blurRadius);
30 29
31 // overrides from SkMaskFilter 30 // overrides from SkMaskFilter
32 // This method is not exported to java. 31 // This method is not exported to java.
33 virtual SkMask::Format getFormat() const SK_OVERRIDE; 32 virtual SkMask::Format getFormat() const SK_OVERRIDE;
34 // This method is not exported to java. 33 // This method is not exported to java.
35 virtual bool filterMask(SkMask* dst, const SkMask& src, const SkMatrix&, 34 virtual bool filterMask(SkMask* dst, const SkMask& src, const SkMatrix&,
36 SkIPoint* margin) const SK_OVERRIDE; 35 SkIPoint* margin) const SK_OVERRIDE;
37 36
38 SkDEVCODE(virtual void toString(SkString* str) const SK_OVERRIDE;) 37 SkDEVCODE(virtual void toString(SkString* str) const SK_OVERRIDE;)
39 SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkEmbossMaskFilter) 38 SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkEmbossMaskFilter)
40 39
41 protected: 40 protected:
42 SkEmbossMaskFilter(SkReadBuffer&); 41 SkEmbossMaskFilter(SkReadBuffer&);
43 virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE; 42 virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE;
44 43
44 #ifdef SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS
45 public:
46 #endif
47 SkEmbossMaskFilter(SkScalar blurSigma, const Light& light);
48
45 private: 49 private:
46 Light fLight; 50 Light fLight;
47 SkScalar fBlurSigma; 51 SkScalar fBlurSigma;
48 52
49 typedef SkMaskFilter INHERITED; 53 typedef SkMaskFilter INHERITED;
50 }; 54 };
51 55
52 #endif 56 #endif
OLDNEW
« no previous file with comments | « include/core/SkMaskFilter.h ('k') | include/effects/SkKernel33MaskFilter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698